Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing locks around nodeIDToDeviceMap access. #28675

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Add missing locks around nodeIDToDeviceMap access. #28675

merged 1 commit into from
Aug 12, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Those accesses are all supposed to happen while holding _deviceMapLock, but we had some that were not locking.

@bzbarsky-apple
Add missing locks around nodeIDToDeviceMap access.
88cafdc 
Those accesses are all supposed to happen while holding _deviceMapLock, but we
had some that were not locking.
@github-actions
Copy link

github-actions bot commented Aug 12, 2023 •
edited
Loading

PR #28675: Size comparison from 1309e7d to 88cafdc

Increases (6 builds for bl702l, esp32, nrfconnect, telink)
platform target config section 1309e7d 88cafdc change % change
bl702l lighting-app bl702l (read/write) 1153808 1153812 4 0.0
.debug_info 41510305 41510306 1 0.0
.text 943828 943830 2 0.0
esp32 all-clusters-app c3devkit (read only) 1151428 1151430 2 0.0
.flash.text 1151428 1151430 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 845148 845152 4 0.0
telink light-switch-app tlsr9518adk80d text 618578 618580 2 0.0
lock-app tlsr9518adk80d text 621520 621522 2 0.0
pump-controller-app tlsr9518adk80d text 586916 586918 2 0.0
Decreases (12 builds for bl602, bl702, efr32, psoc6, telink)
platform target config section 1309e7d 88cafdc change % change
bl602 lighting-app bl602 .text 1057928 1057924 -4 -0.0
bl702 lighting-app bl702+rpc .debug_info 46403895 46403894 -1 -0.0
.text 1029760 1029758 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1037244 1037228 -16 -0.0
.text 869868 869852 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30262562 30262561 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27230585 27230584 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1072388 1072380 -8 -0.0
text 730834 730832 -2 -0.0
bridge-app tlsr9518adk80d text 647460 647458 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 994524 994516 -8 -0.0
text 693730 693728 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d text 594324 594322 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read/write) 865620 865612 -8 -0.0
text 582564 582560 -4 -0.0
thermostat tlsr9518adk80d (read/write) 911452 911444 -8 -0.0
text 621890 621888 -2 -0.0
window-covering tlsr9518adk80d (read/write) 907240 907232 -8 -0.0
text 617198 617196 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 1309e7d 88cafdc change % change
bl602 lighting-app bl602 (read/write) 1365170 1365170 0 0.0
.bss 73622 73622 0 0.0
.data 9560 9560 0 0.0
.text 1057928 1057924 -4 -0.0
bl602+rpc (read/write) 1412638 1412638 0 0.0
.bss 81662 81662 0 0.0
.data 9952 9952 0 0.0
.text 1089858 1089858 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168199 1168199 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1567493 1567493 0 0.0
.debug_aranges 140400 140400 0 0.0
.debug_frame 516640 516640 0 0.0
.debug_info 41509196 41509196 0 0.0
.debug_line 5485389 5485389 0 0.0
.debug_loc 3565999 3565999 0 0.0
.debug_ranges 384712 384712 0 0.0
.debug_str 4012573 4012573 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107196 107196 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589689 589689 0 0.0
.symtab 175808 175808 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955076 955076 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1267135 1267135 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1744623 1744623 0 0.0
.debug_aranges 148944 148944 0 0.0
.debug_frame 545544 545544 0 0.0
.debug_info 46403895 46403894 -1 -0.0
.debug_line 5897911 5897911 0 0.0
.debug_loc 3772155 3772155 0 0.0
.debug_ranges 410464 410464 0 0.0
.debug_str 4432438 4432438 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121848 121848 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652652 652652 0 0.0
.symtab 194736 194736 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029760 1029758 -2 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153808 1153812 4 0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77840 77840 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1569712 1569712 0 0.0
.debug_aranges 134904 134904 0 0.0
.debug_frame 496328 496328 0 0.0
.debug_info 41510305 41510306 1 0.0
.debug_line 5401083 5401083 0 0.0
.debug_loc 3502138 3502138 0 0.0
.debug_ranges 389920 389920 0 0.0
.debug_str 4025042 4025042 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 101080 101080 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589904 589904 0 0.0
.symtab 175360 175360 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943828 943830 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 615962 615962 0 0.0
(read/write) 207744 207744 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201184 201184 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 962080 962080 0 0.0
.debug_aranges 109056 109056 0 0.0
.debug_frame 369852 369852 0 0.0
.debug_info 19423288 19423288 0 0.0
.debug_line 2814419 2814419 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1597625 1597625 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100591 100591 0 0.0
.debug_str 3427188 3427188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106458 106458 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 496476 496476 0 0.0
.symtab 293440 293440 0 0.0
.text 507384 507384 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550647 550647 0 0.0
.app_xip_area 441937 441937 0 0.0
.bss 63728 63728 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537743 537743 0 0.0
.app_xip_area 423985 423985 0 0.0
.bss 68752 68752 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574407 574407 0 0.0
.app_xip_area 466777 466777 0 0.0
.bss 62720 62720 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549399 549399 0 0.0
.app_xip_area 438761 438761 0 0.0
.bss 65632 65632 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013004 1013004 0 0.0
.bss 184524 184524 0 0.0
.data 2652 2652 0 0.0
.text 825808 825808 0 0.0
BRD4187C (read/write) 1037244 1037228 -16 -0.0
.bss 164108 164108 0 0.0
.data 3248 3248 0 0.0
.text 869868 869852 -16 -0.0
lock-app BRD4161A+wf200 (read/write) 1089648 1089648 0 0.0
.bss 178580 178580 0 0.0
.data 2672 2672 0 0.0
.text 908376 908376 0 0.0
window-app BRD4187C (read/write) 1109024 1109024 0 0.0
.bss 147148 147148 0 0.0
.data 3132 3132 0 0.0
.text 958724 958724 0 0.0
esp32 all-clusters-app c3devkit (read only) 1151428 1151430 2 0.0
(read/write) 1702412 1702412 0 0.0
.dram0.bss 79048 79048 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 266536 266536 0 0.0
.flash.text 1151428 1151430 2 0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1193059 1193059 0 0.0
(read/write) 550606 550606 0 0.0
.dram0.bss 85416 85416 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297512 297512 0 0.0
.flash.text 1187675 1187675 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 591012 591012 0 0.0
(read/write) 88096 88096 0 0.0
.bss 71344 71344 0 0.0
.data 2128 2128 0 0.0
.text 590476 590476 0 0.0
light k32w0+release (read only) 589812 589812 0 0.0
(read/write) 87748 87748 0 0.0
.bss 71008 71008 0 0.0
.data 2116 2116 0 0.0
.text 589276 589276 0 0.0
lock k32w0+release (read only) 562148 562148 0 0.0
(read/write) 85548 85548 0 0.0
.bss 68864 68864 0 0.0
.data 2060 2060 0 0.0
.text 561612 561612 0 0.0
linux all-clusters-app debug (read only) 5518193 5518193 0 0.0
(read/write) 418176 418176 0 0.0
.bss 130464 130464 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 276360 276360 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1304 1304 0 0.0
.rodata 336016 336016 0 0.0
.text 4804259 4804259 0 0.0
all-clusters-minimal-app debug (read only) 4902913 4902913 0 0.0
(read/write) 231392 231392 0 0.0
.bss 126016 126016 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94384 94384 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272102 272102 0 0.0
.text 4400611 4400611 0 0.0
bridge-app debug (read only) 2770593 2770593 0 0.0
(read/write) 132848 132848 0 0.0
.bss 51512 51512 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71408 71408 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214664 214664 0 0.0
.text 2378403 2378403 0 0.0
chip-tool debug (read only) 17528481 17528481 0 0.0
(read/write) 1043136 1043136 0 0.0
.bss 93752 93752 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 936936 936936 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 892049 892049 0 0.0
.text 14610179 14610179 0 0.0
chip-tool-ipv6only arm64 (read only) 16770644 16770644 0 0.0
(read/write) 1110520 1110520 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 974328 974328 0 0.0
.dynamic 512 512 0 0.0
.got 23248 23248 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 804416 804416 0 0.0
.text 13755528 13755528 0 0.0
lighting-app debug+rpc+ui (read only) 5242001 5242001 0 0.0
(read/write) 222088 222088 0 0.0
.bss 117744 117744 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337108 337108 0 0.0
.text 4662819 4662819 0 0.0
lock-app debug (read only) 4473057 4473057 0 0.0
(read/write) 202840 202840 0 0.0
.bss 113360 113360 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248038 248038 0 0.0
.text 4015667 4015667 0 0.0
ota-provider-app debug (read only) 4128329 4128329 0 0.0
(read/write) 191872 191872 0 0.0
.bss 113504 113504 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201254 201254 0 0.0
.text 3736755 3736755 0 0.0
ota-requestor-app debug (read only) 4222225 4222225 0 0.0
(read/write) 196184 196184 0 0.0
.bss 114560 114560 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204646 204646 0 0.0
.text 3822931 3822931 0 0.0
shell debug (read only) 2939049 2939049 0 0.0
(read/write) 150720 150720 0 0.0
.bss 60008 60008 0 0.0
.data 784 784 0 0.0
.data.rel.ro 84056 84056 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 212370 212370 0 0.0
.text 2555714 2555714 0 0.0
thermostat-no-ble arm64 (read only) 4451476 4451476 0 0.0
(read/write) 243848 243848 0 0.0
.bss 122280 122280 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102232 102232 0 0.0
.dynamic 512 512 0 0.0
.got 11984 11984 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 162252 162252 0 0.0
.text 3951144 3951144 0 0.0
tv-app debug (read only) 5317361 5317361 0 0.0
(read/write) 349856 349856 0 0.0
.bss 241280 241280 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272598 272598 0 0.0
.text 4801123 4801123 0 0.0
tv-casting-app debug (read only) 8296737 8296737 0 0.0
(read/write) 210568 210568 0 0.0
.bss 54208 54208 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 367836 367836 0 0.0
.text 7528739 7528739 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522504 2522504 0 0.0
.bss 219904 219904 0 0.0
.data 5128 5128 0 0.0
.text 1485188 1485188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1220412 1220412 0 0.0
bss 154612 154612 0 0.0
rodata 141696 141696 0 0.0
text 845148 845152 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1338624 1338624 0 0.0
bss 140070 140070 0 0.0
rodata 135688 135688 0 0.0
text 772180 772180 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1157328 1157328 0 0.0
bss 154791 154791 0 0.0
rodata 113036 113036 0 0.0
text 810516 810516 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837688 837688 0 0.0
(read/write) 1768804 1768804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193116 193116 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2536 2536 0 0.0
.debug_abbrev 1382477 1382477 0 0.0
.debug_aranges 143944 143944 0 0.0
.debug_frame 479472 479472 0 0.0
.debug_info 30262562 30262561 -1 -0.0
.debug_line 4150562 4150562 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2249376 2249376 0 0.0
.debug_rnglists 142398 142398 0 0.0
.debug_str 4124989 4124989 0 0.0
.heap 837688 837688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 806034 806034 0 0.0
.symtab 501808 501808 0 0.0
.text 1564764 1564764 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839648 839648 0 0.0
(read/write) 1674572 1674572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191228 191228 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1285184 1285184 0 0.0
.debug_aranges 137208 137208 0 0.0
.debug_frame 462420 462420 0 0.0
.debug_info 27230585 27230584 -1 -0.0
.debug_line 3961702 3961702 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2149738 2149738 0 0.0
.debug_rnglists 135498 135498 0 0.0
.debug_str 3979410 3979410 0 0.0
.heap 839648 839648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 713485 713485 0 0.0
.symtab 465936 465936 0 0.0
.text 1472492 1472492 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845912 845912 0 0.0
(read/write) 1606076 1606076 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185076 185076 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1125407 1125407 0 0.0
.debug_aranges 127336 127336 0 0.0
.debug_frame 425564 425564 0 0.0
.debug_info 22372915 22372915 0 0.0
.debug_line 3527007 3527007 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1986853 1986853 0 0.0
.debug_rnglists 125268 125268 0 0.0
.debug_str 3787482 3787482 0 0.0
.heap 845912 845912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634477 634477 0 0.0
.symtab 430576 430576 0 0.0
.text 1410260 1410260 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818392 818392 0 0.0
(read/write) 1639580 1639580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212580 212580 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1116871 1116871 0 0.0
.debug_aranges 126248 126248 0 0.0
.debug_frame 421592 421592 0 0.0
.debug_info 22286449 22286449 0 0.0
.debug_line 3482458 3482458 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1967262 1967262 0 0.0
.debug_rnglists 123444 123444 0 0.0
.debug_str 3752020 3752020 0 0.0
.heap 818392 818392 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 608377 608377 0 0.0
.symtab 422704 422704 0 0.0
.text 1416244 1416244 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178444 1178444 0 0.0
.bss 101176 101176 0 0.0
.data 744 744 0 0.0
.text 625288 625288 0 0.0
lock-app qpg6105+debug (read/write) 1135500 1135500 0 0.0
.bss 95896 95896 0 0.0
.data 748 748 0 0.0
.text 582340 582340 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1072388 1072380 -8 -0.0
bss 107308 107308 0 0.0
text 730834 730832 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 977504 977504 0 0.0
bss 105284 105284 0 0.0
text 670206 670206 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944904 944904 0 0.0
bss 109660 109660 0 0.0
text 647460 647458 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876860 876860 0 0.0
bss 98840 98840 0 0.0
text 590848 590848 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 908164 908164 0 0.0
bss 99464 99464 0 0.0
text 618578 618580 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 983160 983160 0 0.0
bss 107516 107516 0 0.0
text 686214 686214 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 994524 994516 -8 -0.0
bss 111764 111764 0 0.0
text 693730 693728 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1052684 1052684 0 0.0
bss 109088 109088 0 0.0
text 731146 731146 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1084004 1084004 0 0.0
bss 120164 120164 0 0.0
text 751248 751248 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934312 934312 0 0.0
bss 99560 99560 0 0.0
text 621520 621522 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899440 899440 0 0.0
bss 100148 100148 0 0.0
text 612690 612690 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882260 882260 0 0.0
bss 98972 98972 0 0.0
text 596452 596452 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869440 869440 0 0.0
bss 98772 98772 0 0.0
text 586916 586918 2 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744196 744196 0 0.0
bss 97208 97208 0 0.0
text 478660 478660 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879344 879344 0 0.0
bss 98952 98952 0 0.0
text 594324 594322 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865620 865612 -8 -0.0
bss 98680 98680 0 0.0
text 582564 582560 -4 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 911452 911444 -8 -0.0
bss 99224 99224 0 0.0
text 621890 621888 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907240 907232 -8 -0.0
bss 99560 99560 0 0.0
text 617198 617196 -2 -0.0

@mergify mergify bot merged commit b0b0d58 into project-chip:master Aug 12, 2023
abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Aug 15, 2023
@bzbarsky-apple
Add missing locks around nodeIDToDeviceMap access. (project-chip#28675)
c8a682b 
Those accesses are all supposed to happen while holding _deviceMapLock, but we
had some that were not locking.
@bzbarsky-apple bzbarsky-apple deleted the add-missing-locking branch August 21, 2023 13:29
s07641069 pushed a commit to s07641069/connectedhomeip that referenced this pull request Aug 22, 2023
@bzbarsky-apple @s07641069
Add missing locks around nodeIDToDeviceMap access. (project-chip#28675)
c07070f 
Those accesses are all supposed to happen while holding _deviceMapLock, but we
had some that were not locking.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@bzbarsky-apple @HunsupJung
Add missing locks around nodeIDToDeviceMap access. (project-chip#28675)
09bd12d 
Those accesses are all supposed to happen while holding _deviceMapLock, but we
had some that were not locking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yunhanw-google @jtung-apple