-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable wconversion for matter controller java/jni #28667
enable wconversion for matter controller java/jni #28667
Conversation
PR #28667: Size comparison from 9a35c44 to 05ddf01 Decreases (1 build for nrfconnect)
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
05ddf01
to
5aec155
Compare
PR #28667: Size comparison from 9a35c44 to 5aec155 Increases (8 builds for esp32, psoc6, telink)
Decreases (7 builds for bl602, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as all those unchecked casts are ok....
5aec155
to
4e2c23c
Compare
i prefer doing the mandatory casting for all jni type when it needs to be converted to native c type for type safe. I would work on this |
PR #28667: Size comparison from d928f3c to f2022e9 Increases (12 builds for bl702l, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc32xx, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
controller java/jni layer has not yet enabled wconversion, enable it, fix across.