-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make AddStatus generally VerifyOrDie and have centralized logging (#28634)" #28661
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:revert-command-status-change
Aug 11, 2023
Merged
Revert "Make AddStatus generally VerifyOrDie and have centralized logging (#28634)" #28661
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:revert-command-status-change
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging (project-chip#28634)" This reverts commit a98bc64. The revert is happening because of OpenIOT SDK perma-fail after that PR merged.
jmartinez-silabs
approved these changes
Aug 11, 2023
PR #28661: Size comparison from bf0b45a to 311df74 Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (23 builds for bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a98bc64.
The revert is happening because of OpenIOT SDK perma-fail after that PR merged.