-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power source: add device type to zap files #28647
Merged
yufengwangca
merged 6 commits into
project-chip:master
from
cecille:power_source_add_device_type_attempt_3
Aug 16, 2023
Merged
Power source: add device type to zap files #28647
yufengwangca
merged 6 commits into
project-chip:master
from
cecille:power_source_add_device_type_attempt_3
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 11, 2023 01:07
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
August 11, 2023 01:08
pullapprove
bot
added
review - pending
examples
scripts
and removed
examples
scripts
labels
Aug 11, 2023
PR #28647: Size comparison from a98bc64 to fc3543c Increases above 0.2%:
Increases (28 builds for bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (6 builds for psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 11, 2023
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
Outdated
Show resolved
Hide resolved
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
Show resolved
Hide resolved
examples/lighting-app/silabs/data_model/lighting-thread-app.matter
Outdated
Show resolved
Hide resolved
examples/lighting-app/silabs/data_model/lighting-wifi-app.matter
Outdated
Show resolved
Hide resolved
PR #28647: Size comparison from a98bc64 to 8986f3c Increases above 0.2%:
Increases (57 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (21 builds for bl702, bl702l, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (59 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Aug 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Add power device type * Zap regen * Change back reportable changes introduced by zap * re-run zap gen * Update descriptor test to include power cluster * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added power source device type to the device type list for any example endpoints that include the power source cluster
Note that the other zap changes come from opening zap in the gui and saving.