-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding laundry washer controls to all clusters #28616
Adding laundry washer controls to all clusters #28616
Conversation
PR #28616: Size comparison from 96426f3 to cd2d36e Increases above 0.2%:
Increases (13 builds for bl602, esp32, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, bl702l, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
PR #28616: Size comparison from 96426f3 to 739762e Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, bl702l, cc32xx, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28616: Size comparison from 96426f3 to a3e1373 Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for linux, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but @abeck-whirlpool note that ZAP failure: you need to rerun codegen to regenerate the .matter file. Something like this is probably fastest:
./scripts/tools/zap/generate.py examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
PR #28616: Size comparison from 96426f3 to 62de4bc Increases above 0.2%:
Increases (52 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (21 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28616: Size comparison from a98bc64 to e9f0325 Increases above 0.2%:
Increases (19 builds for bl602, bl702, bl702l, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…thub.com/abeck-whirlpool/connectedhomeip into quickfix/TestAppTE2LaundryWasherControls
PR #28616: Size comparison from a98bc64 to 4268930 Increases above 0.2%:
Increases (24 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for cc32xx, cyw30739, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably revert all these Android java changes. They are causing your CI to fail.
(They're here because you ran regen-all and don't have java
installed to reformat those files....)
This reverts commit 8d1dcf6.
@abeck-whirlpool Sorry, this merged preemptively. Can you re-open this PR and fix the ZAP failures? Sorry :( |
Co-authored-by: abeck-riis <[email protected]>
Co-authored-by: abeck-riis <[email protected]>
Co-authored-by: abeck-riis <[email protected]>
Adding laundry washer controls cluster to all-clusters example app for validation during TE2