-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out python dependencies for running scripts #28582
Merged
andy31415
merged 10 commits into
project-chip:master
from
andy31415:separate_py_requirements
Aug 9, 2023
Merged
Separate out python dependencies for running scripts #28582
andy31415
merged 10 commits into
project-chip:master
from
andy31415:separate_py_requirements
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
August 8, 2023 17:44
PR #28582: Size comparison from 0342ae4 to a155e5c Increases (5 builds for telink)
Decreases (11 builds for bl602, bl702, cc32xx, cyw30739, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mikaelhm
approved these changes
Aug 8, 2023
saurabhst
approved these changes
Aug 8, 2023
Fast track: CSG + 1 more approval. This should only affect building and docker images, not functionality. |
PR #28582: Size comparison from 0342ae4 to 6b12d77 Increases (3 builds for esp32, linux, psoc6)
Decreases (53 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28582: Size comparison from e1d9749 to b7c6d1d Increases (7 builds for bl702, cc32xx, esp32, telink)
Decreases (10 builds for bl602, efr32, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 9, 2023
PR #28582: Size comparison from e1d9749 to 722c6ad Decreases (2 builds for cc32xx, mbed)
Full report (2 builds for cc32xx, mbed)
|
PR #28582: Size comparison from e1d9749 to 249519b Increases (10 builds for bl702, cc32xx, esp32, psoc6, telink)
Decreases (11 builds for bl602, efr32, linux, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mikaelhm
approved these changes
Aug 9, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
) * Separate oput requirements for various python scripts * Update certbins to install requirements for test script running instead of hard-coding dependencies * Update text for help in build_python * Fix the requirements install - need to copy the dependencies locally * Update the sha to something that supports the latest options. This is the TE2 for 1.2 SHA * A few more dependencies for py_matter_yamltests ... dependencies there seem off * Revert submodule updates * Update dependencies for chip repl to allow py_matter_idl * Fix dependencies in yaml: need dependencies at runtime not at build time --------- Co-authored-by: Andrei Litvin <[email protected]>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
) * Separate oput requirements for various python scripts * Update certbins to install requirements for test script running instead of hard-coding dependencies * Update text for help in build_python * Fix the requirements install - need to copy the dependencies locally * Update the sha to something that supports the latest options. This is the TE2 for 1.2 SHA * A few more dependencies for py_matter_yamltests ... dependencies there seem off * Revert submodule updates * Update dependencies for chip repl to allow py_matter_idl * Fix dependencies in yaml: need dependencies at runtime not at build time --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I expect this fixes #28580