-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate if the Current Group = RemovedGroup before invalidating scene #28565
Validate if the Current Group = RemovedGroup before invalidating scene #28565
Conversation
… is in RemovedGroup before invalidating the scene.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this passes CI, we need better tests.
PR #28565: Size comparison from 963a859 to 3564e53 Increases (4 builds for k32w, nrfconnect)
Decreases (1 build for cc32xx)
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #28565: Size comparison from 963a859 to 6997709 Increases (35 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for cc32xx, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28565: Size comparison from 963a859 to 58eff19 Increases (38 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for bl702l, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28565: Size comparison from 963a859 to 6565bda Increases (30 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (30 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #28565: Size comparison from 963a859 to c17aa28 Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc32xx, linux, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
project-chip#28565) * Validate if the Current Group = RemovedGroup or check if CurrentScene is in RemovedGroup before invalidating the scene. * Fix nonsensical code * ditto * ditto bis * restyle * Remove check that was not specification compliant * Cleanup * Update src/app/clusters/scenes-server/scenes-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
project-chip#28565) * Validate if the Current Group = RemovedGroup or check if CurrentScene is in RemovedGroup before invalidating the scene. * Fix nonsensical code * ditto * ditto bis * restyle * Remove check that was not specification compliant * Cleanup * Update src/app/clusters/scenes-server/scenes-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Validate if the Current Group = RemovedGroup
or check if CurrentScene is in RemovedGroupbefore invalidating the scene.Fixes : #26884