-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve size calculation for our packets. #28563
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-packet-sizes
Aug 8, 2023
Merged
Improve size calculation for our packets. #28563
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-packet-sizes
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
better-packet-sizes
branch
from
August 7, 2023 14:27
f2d8f4c
to
c79c3af
Compare
PR #28563: Size comparison from 35cb562 to c79c3af Increases (23 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 7, 2023 15:32
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 7, 2023 15:32
We were hardcoding kMaxAppMessageLen and kMaxSecureSduLengthBytes, but those defines were not even consistent with each other, and both were overly conservative. Specific changes: 1. Fix computation of CHIP_SYSTEM_HEADER_RESERVE_SIZE: we don't have any "crypto headers". 2. Fix computation of kMaxAppMessageLen to use our actual packet buffer sizes and defined header sizes. 3. Fix kMaxSecureSduLengthBytes to be consistent with kMaxAppMessageLen.
bzbarsky-apple
force-pushed
the
better-packet-sizes
branch
from
August 7, 2023 19:24
c79c3af
to
eb00a31
Compare
pidarped
reviewed
Aug 7, 2023
PR #28563: Size comparison from 963a859 to eb00a31 Increases (10 builds for bl602, bl702, bl702l, cc32xx, k32w, nrfconnect)
Decreases (3 builds for bl702, cc32xx)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #28563: Size comparison from 963a859 to 6b46996 Increases (23 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, bl702l, cc32xx, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pidarped
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Improve size calculation for our packets. We were hardcoding kMaxAppMessageLen and kMaxSecureSduLengthBytes, but those defines were not even consistent with each other, and both were overly conservative. Specific changes: 1. Fix computation of CHIP_SYSTEM_HEADER_RESERVE_SIZE: we don't have any "crypto headers". 2. Fix computation of kMaxAppMessageLen to use our actual packet buffer sizes and defined header sizes. 3. Fix kMaxSecureSduLengthBytes to be consistent with kMaxAppMessageLen. * Simplify the size computation logic.
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…p#28563) * Improve size calculation for our packets. We were hardcoding kMaxAppMessageLen and kMaxSecureSduLengthBytes, but those defines were not even consistent with each other, and both were overly conservative. Specific changes: 1. Fix computation of CHIP_SYSTEM_HEADER_RESERVE_SIZE: we don't have any "crypto headers". 2. Fix computation of kMaxAppMessageLen to use our actual packet buffer sizes and defined header sizes. 3. Fix kMaxSecureSduLengthBytes to be consistent with kMaxAppMessageLen. * Simplify the size computation logic.
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…ject-chip#28563)" This reverts commit 1b5019a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hardcoding kMaxAppMessageLen and kMaxSecureSduLengthBytes, but those defines were not even consistent with each other, and both were overly conservative. Specific changes: