-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controllers not advertising their operational identities. #28537
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:no-advertise-if-not-wanted
Aug 8, 2023
Merged
Add support for controllers not advertising their operational identities. #28537
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:no-advertise-if-not-wanted
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
August 5, 2023 00:52
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 5, 2023 00:52
bzbarsky-apple
force-pushed
the
no-advertise-if-not-wanted
branch
from
August 5, 2023 00:53
d72fee1
to
7cbb182
Compare
PR #28537: Size comparison from fe75cd1 to 7cbb182 Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ies. If multiple controllers are running, and some want to enable server interactions while others do not, the ones not enabling server interactions should not advertise. Fixes project-chip#28279
bzbarsky-apple
force-pushed
the
no-advertise-if-not-wanted
branch
from
August 5, 2023 03:54
7cbb182
to
5cb44d0
Compare
PR #28537: Size comparison from fe75cd1 to 5cb44d0 Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 7, 2023
jtung-apple
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…ies. (project-chip#28537) If multiple controllers are running, and some want to enable server interactions while others do not, the ones not enabling server interactions should not advertise. Fixes project-chip#28279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple controllers are running, and some want to enable server interactions while others do not, the ones not enabling server interactions should not advertise.
Fixes #28279