-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues in TC-DRLK-2.1 #28509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Perform Lock/Unlock operations with User/PIN is F.PIN and F.COTA are supported - Allow RequirePINforRemoteOperation attribute to be TRUE or FALSE - Allow EnablePrivacyModeButton attribute to be either TRUE or FALSE - Allow EnableInsideStatusLED attribute to be either TRUE or FALSE - Allow EnableOneTouchLocking attribute to be either TRUE or FALSE - Allow EnableLocalProgramming attribute to be either TRUE or FALSE - Allow SupportedOperatingModes attribute to be any of the valid combinations Fixes project-chip#598
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
August 3, 2023 20:40
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 3, 2023 20:40
PR #28509: Size comparison from b3d3685 to 624ee39 Increases (10 builds for bl602, cc32xx, cyw30739, psoc6, telink)
Decreases (10 builds for bl702, bl702l, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2023
bzbarsky-apple
requested changes
Aug 5, 2023
bzbarsky-apple
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming https://github.com/CHIP-Specifications/chip-test-plans/pull/3279 merges in its current form.
andy31415
approved these changes
Aug 10, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Fix various issues in TC-DRLK-2.1: - Perform Lock/Unlock operations with User/PIN is F.PIN and F.COTA are supported - Allow RequirePINforRemoteOperation attribute to be TRUE or FALSE - Allow EnablePrivacyModeButton attribute to be either TRUE or FALSE - Allow EnableInsideStatusLED attribute to be either TRUE or FALSE - Allow EnableOneTouchLocking attribute to be either TRUE or FALSE - Allow EnableLocalProgramming attribute to be either TRUE or FALSE - Allow SupportedOperatingModes attribute to be any of the valid combinations Fixes project-chip#598 * Restyled by whitespace * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* Fix various issues in TC-DRLK-2.1: - Perform Lock/Unlock operations with User/PIN is F.PIN and F.COTA are supported - Allow RequirePINforRemoteOperation attribute to be TRUE or FALSE - Allow EnablePrivacyModeButton attribute to be either TRUE or FALSE - Allow EnableInsideStatusLED attribute to be either TRUE or FALSE - Allow EnableOneTouchLocking attribute to be either TRUE or FALSE - Allow EnableLocalProgramming attribute to be either TRUE or FALSE - Allow SupportedOperatingModes attribute to be any of the valid combinations Fixes project-chip#598 * Restyled by whitespace * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various issues in TC-DRLK-2.1
Corresponding Test Plan changes: https://github.com/CHIP-Specifications/chip-test-plans/pull/3279
Fixes #598 (https://github.com/CHIP-Specifications/chip-test-scripts/issues/598)