-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android, Java] Fix JNI Type casting issue #28464
Merged
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:fix_jni_type_casting_issue
Aug 7, 2023
Merged
[Android, Java] Fix JNI Type casting issue #28464
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:fix_jni_type_casting_issue
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28464: Size comparison from 0d81aa5 to 6f8539d Increases (1 build for nrfconnect)
Decreases (1 build for k32w)
Full report (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #28464: Size comparison from 0d81aa5 to b6e0900 Increases (7 builds for cyw30739, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Aug 3, 2023
yufengwangca
approved these changes
Aug 4, 2023
… fix_jni_type_casting_issue
…connectedhomeip into fix_jni_type_casting_issue
I updated ZAP version. And, I ran zap_regen_all.py script. |
PR #28464: Size comparison from 8363494 to 4bfc3e2 Increases (10 builds for k32w, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, bl702l, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28464: Size comparison from 32efabd to 4f1ce2b Increases (5 builds for bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (12 builds for bl702l, efr32, esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Fix Jni Typecasting issue * Restyled by clang-format * Update ZAP version * Zap generated --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27621
In the case of a 32-bit device, there is a problem that uint32_t is not cast to Java long boxed type.
To solve this issue, I changed it so that it can be saved as a normal value by casting to a local variable of jni type in advance.
However, the ZAP creation script has some problems, so this script also needs to be modified.
project-chip/zap#1092