-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a FabricTable API to get the next available fabric index. #28391
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-fabric-table-next-index
Aug 1, 2023
Merged
Add a FabricTable API to get the next available fabric index. #28391
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-fabric-table-next-index
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
July 29, 2023 03:27
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 29, 2023 03:27
PR #28391: Size comparison from 2a681e3 to 9ad281a Increases (33 builds for bl602, bl702, bl702l, cc32xx, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, esp32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This can be used during controller startup to map the fabric index (which is allocated to the controller partway through startup and then used immediately for storage keys) to the controller instance being started.
bzbarsky-apple
force-pushed
the
add-fabric-table-next-index
branch
from
July 30, 2023 06:11
9ad281a
to
8ea4d18
Compare
bzbarsky-apple
changed the title
Add a FabricTable API to get the next availabe fabric index.
Add a FabricTable API to get the next available fabric index.
Jul 30, 2023
PR #28391: Size comparison from 693ef72 to 8ea4d18 Increases (29 builds for bl702, bl702l, cc32xx, nrfconnect, psoc6, telink)
Decreases (3 builds for bl602, efr32, esp32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pidarped
reviewed
Jul 30, 2023
pidarped
approved these changes
Jul 31, 2023
tcarmelveilleux
approved these changes
Jul 31, 2023
PR #28391: Size comparison from 693ef72 to 73ee6d4 Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for k32w)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used during controller startup to map the fabric index (which is allocated to the controller partway through startup and then used immediately for storage keys) to the controller instance being started.