Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controller startup a bit to share more code. #28385

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Refactor controller startup a bit to share more code. #28385

merged 1 commit into from
Jul 29, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

There was a lot of identical boilerplate between createControllerOnNewFabric and createControllerOnExistingFabric.

checkIsRunning already sets error, which is why the setting of error if that returns false was removed.

@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

PR #28385: Size comparison from 0be73c8 to 8143414

Increases (10 builds for bl702, esp32, nrfconnect, psoc6, telink)
platform target config section 0be73c8 8143414 change % change
bl702 lighting-app bl702 (read/write) 1164599 1164603 4 0.0
.debug_info 41279389 41279391 2 0.0
.text 952252 952256 4 0.0
bl702+rpc (read/write) 1263467 1263471 4 0.0
.debug_info 46152645 46152646 1 0.0
.text 1026916 1026918 2 0.0
esp32 all-clusters-app m5stack (read/write) 500434 500438 4 0.0
.flash.rodata 248092 248096 4 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 769660 769664 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30038327 30038328 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27166572 27166573 1 0.0
light cy8ckit_062s2_43012 .debug_info 22321723 22321724 1 0.0
telink shell tlsr9518adk80d (read/write) 744124 744132 8 0.0
text 478572 478574 2 0.0
smoke_co_alarm-app tlsr9518adk80d text 591766 591768 2 0.0
thermostat tlsr9518adk80d text 619880 619882 2 0.0
Decreases (10 builds for bl602, cc32xx, efr32, esp32, telink)
platform target config section 0be73c8 8143414 change % change
bl602 lighting-app bl602 .text 1055588 1055586 -2 -0.0
bl602+rpc .text 1087502 1087500 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19072473 19072471 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1033564 1033556 -8 -0.0
.text 867004 866996 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1095534 1095532 -2 -0.0
(read/write) 1590056 1590048 -8 -0.0
.flash.rodata 219552 219544 -8 -0.0
.flash.text 1095534 1095532 -2 -0.0
telink all-clusters-app tlsr9518adk80d text 727146 727144 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 667774 667772 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 902816 902808 -8 -0.0
text 614358 614356 -2 -0.0
lighting-app-factory-data tlsr9518adk80d text 691740 691738 -2 -0.0
pump-controller-app tlsr9518adk80d (read/write) 866556 866548 -8 -0.0
text 584838 584836 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0be73c8 8143414 change % change
bl602 lighting-app bl602 (read/write) 1361970 1361970 0 0.0
.bss 73806 73806 0 0.0
.data 9608 9608 0 0.0
.text 1055588 1055586 -2 -0.0
bl602+rpc (read/write) 1409414 1409414 0 0.0
.bss 81846 81846 0 0.0
.data 10008 10008 0 0.0
.text 1087502 1087500 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1164599 1164603 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41237 41237 0 0.0
.bss_psram 43680 43680 0 0.0
.comment 48 48 0 0.0
.data 3600 3600 0 0.0
.debug_abbrev 1564080 1564080 0 0.0
.debug_aranges 140136 140136 0 0.0
.debug_frame 515452 515452 0 0.0
.debug_info 41279389 41279391 2 0.0
.debug_line 5469245 5469245 0 0.0
.debug_loc 3558169 3558169 0 0.0
.debug_ranges 384168 384168 0 0.0
.debug_str 4008650 4008650 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106096 106096 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 587740 587740 0 0.0
.symtab 175200 175200 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952252 952256 4 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1263467 1263471 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49685 49685 0 0.0
.bss_psram 43680 43680 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1741255 1741255 0 0.0
.debug_aranges 148672 148672 0 0.0
.debug_frame 544320 544320 0 0.0
.debug_info 46152645 46152646 1 0.0
.debug_line 5881684 5881684 0 0.0
.debug_loc 3764132 3764132 0 0.0
.debug_ranges 409912 409912 0 0.0
.debug_str 4428504 4428504 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120748 120748 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 650703 650703 0 0.0
.symtab 194128 194128 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1026916 1026918 2 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1150424 1150424 0 0.0
.boot2 292 292 0 0.0
.bss 15924 15924 0 0.0
.bss_psram 78096 78096 0 0.0
.comment 48 48 0 0.0
.data 4568 4568 0 0.0
.debug_abbrev 1566299 1566299 0 0.0
.debug_aranges 134640 134640 0 0.0
.debug_frame 495140 495140 0 0.0
.debug_info 41280498 41280498 0 0.0
.debug_line 5384813 5384813 0 0.0
.debug_loc 3494338 3494338 0 0.0
.debug_ranges 389376 389376 0 0.0
.debug_str 4021107 4021107 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 140 140 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99980 99980 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 587965 587965 0 0.0
.symtab 174768 174768 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
941314 941314 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 610370 610370 0 0.0
(read/write) 208284 208284 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201696 201696 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 947836 947836 0 0.0
.debug_aranges 108032 108032 0 0.0
.debug_frame 366676 366676 0 0.0
.debug_info 19072473 19072471 -2 -0.0
.debug_line 2783805 2783805 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1581595 1581595 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 99685 99685 0 0.0
.debug_str 3416700 3416700 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105250 105250 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 490115 490115 0 0.0
.symtab 290064 290064 0 0.0
.text 502996 502996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 548927 548927 0 0.0
.app_xip_area 440017 440017 0 0.0
.bss 63880 63880 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 533255 533255 0 0.0
.app_xip_area 419385 419385 0 0.0
.bss 68832 68832 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571927 571927 0 0.0
.app_xip_area 464105 464105 0 0.0
.bss 62840 62840 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 545367 545367 0 0.0
.app_xip_area 434577 434577 0 0.0
.bss 65728 65728 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008628 1008628 0 0.0
.bss 183636 183636 0 0.0
.data 2692 2692 0 0.0
.text 822280 822280 0 0.0
BRD4187C (read/write) 1033564 1033556 -8 -0.0
.bss 163252 163252 0 0.0
.data 3288 3288 0 0.0
.text 867004 866996 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1083616 1083616 0 0.0
.bss 177652 177652 0 0.0
.data 2688 2688 0 0.0
.text 903256 903256 0 0.0
window-app BRD4187C (read/write) 1104604 1104604 0 0.0
.bss 146244 146244 0 0.0
.data 3200 3200 0 0.0
.text 955140 955140 0 0.0
esp32 all-clusters-app c3devkit (read only) 1095534 1095532 -2 -0.0
(read/write) 1590056 1590048 -8 -0.0
.dram0.bss 77368 77368 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 219552 219544 -8 -0.0
.flash.text 1095534 1095532 -2 -0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1141887 1141887 0 0.0
(read/write) 500434 500438 4 0.0
.dram0.bss 82848 82848 0 0.0
.dram0.data 34344 34344 0 0.0
.flash.rodata 248092 248096 4 0.0
.flash.text 1136503 1136503 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 588668 588668 0 0.0
(read/write) 91480 91480 0 0.0
.bss 67476 67476 0 0.0
.data 2168 2168 0 0.0
.text 588132 588132 0 0.0
light k32w0+release (read only) 587356 587356 0 0.0
(read/write) 91112 91112 0 0.0
.bss 67124 67124 0 0.0
.data 2156 2156 0 0.0
.text 586820 586820 0 0.0
lock k32w0+release (read only) 559900 559900 0 0.0
(read/write) 88936 88936 0 0.0
.bss 65012 65012 0 0.0
.data 2100 2100 0 0.0
.text 559364 559364 0 0.0
linux all-clusters-app debug (read only) 5478993 5478993 0 0.0
(read/write) 417264 417264 0 0.0
.bss 129920 129920 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 275584 275584 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 332816 332816 0 0.0
.text 4769555 4769555 0 0.0
all-clusters-minimal-app debug (read only) 4894073 4894073 0 0.0
(read/write) 231280 231280 0 0.0
.bss 125600 125600 0 0.0
.data 4304 4304 0 0.0
.data.rel.ro 94248 94248 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 270918 270918 0 0.0
.text 4393171 4393171 0 0.0
bridge-app debug (read only) 2763233 2763233 0 0.0
(read/write) 132936 132936 0 0.0
.bss 50680 50680 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 71272 71272 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 213480 213480 0 0.0
.text 2372419 2372419 0 0.0
chip-tool debug (read only) 17752889 17752889 0 0.0
(read/write) 1054936 1054936 0 0.0
.bss 93592 93592 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 948848 948848 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 914537 914537 0 0.0
.text 14783539 14783539 0 0.0
chip-tool-ipv6only arm64 (read only) 16968124 16968124 0 0.0
(read/write) 1122488 1122488 0 0.0
.bss 102984 102984 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 986224 986224 0 0.0
.dynamic 512 512 0 0.0
.got 23344 23344 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 825848 825848 0 0.0
.text 13902824 13902824 0 0.0
lighting-app debug+rpc+ui (read only) 5272137 5272137 0 0.0
(read/write) 222184 222184 0 0.0
.bss 117616 117616 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 92112 92112 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337524 337524 0 0.0
.text 4692707 4692707 0 0.0
lock-app debug (read only) 4451681 4451681 0 0.0
(read/write) 202120 202120 0 0.0
.bss 112944 112944 0 0.0
.data 4048 4048 0 0.0
.data.rel.ro 78368 78368 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 246150 246150 0 0.0
.text 3997187 3997187 0 0.0
ota-provider-app debug (read only) 4121849 4121849 0 0.0
(read/write) 191992 191992 0 0.0
.bss 113504 113504 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 68320 68320 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 199942 199942 0 0.0
.text 3731779 3731779 0 0.0
ota-requestor-app debug (read only) 4215841 4215841 0 0.0
(read/write) 196304 196304 0 0.0
.bss 114432 114432 0 0.0
.data 4624 4624 0 0.0
.data.rel.ro 71320 71320 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 203430 203430 0 0.0
.text 3817955 3817955 0 0.0
shell debug (read only) 2922305 2922305 0 0.0
(read/write) 150616 150616 0 0.0
.bss 59592 59592 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 83896 83896 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 208786 208786 0 0.0
.text 2542818 2542818 0 0.0
thermostat-no-ble arm64 (read only) 4445156 4445156 0 0.0
(read/write) 243992 243992 0 0.0
.bss 122200 122200 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 102168 102168 0 0.0
.dynamic 512 512 0 0.0
.got 11960 11960 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161324 161324 0 0.0
.text 3945976 3945976 0 0.0
tv-app debug (read only) 5309297 5309297 0 0.0
(read/write) 349944 349944 0 0.0
.bss 240416 240416 0 0.0
.data 6224 6224 0 0.0
.data.rel.ro 95904 95904 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 271446 271446 0 0.0
.text 4794403 4794403 0 0.0
tv-casting-app debug (read only) 8287153 8287153 0 0.0
(read/write) 210528 210528 0 0.0
.bss 54112 54112 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 146712 146712 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 366492 366492 0 0.0
.text 7521075 7521075 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2517080 2517080 0 0.0
.bss 220432 220432 0 0.0
.data 5152 5152 0 0.0
.text 1479764 1479764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1216456 1216456 0 0.0
bss 154659 154659 0 0.0
rodata 140668 140668 0 0.0
text 842000 842000 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1335756 1335756 0 0.0
bss 140117 140117 0 0.0
rodata 135188 135188 0 0.0
text 769660 769664 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1154372 1154372 0 0.0
bss 154838 154838 0 0.0
rodata 112056 112056 0 0.0
text 808444 808444 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837120 837120 0 0.0
(read/write) 1764940 1764940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193596 193596 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2624 2624 0 0.0
.debug_abbrev 1376055 1376055 0 0.0
.debug_aranges 143504 143504 0 0.0
.debug_frame 478148 478148 0 0.0
.debug_info 30038327 30038328 1 0.0
.debug_line 4133056 4133056 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2241517 2241517 0 0.0
.debug_rnglists 142019 142019 0 0.0
.debug_str 4114532 4114532 0 0.0
.heap 837120 837120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 800233 800233 0 0.0
.symtab 498864 498864 0 0.0
.text 1560332 1560332 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839072 839072 0 0.0
(read/write) 1672404 1672404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191708 191708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1285416 1285416 0 0.0
.debug_aranges 137008 137008 0 0.0
.debug_frame 461936 461936 0 0.0
.debug_info 27166572 27166573 1 0.0
.debug_line 3956018 3956018 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2144678 2144678 0 0.0
.debug_rnglists 135312 135312 0 0.0
.debug_str 3976139 3976139 0 0.0
.heap 839072 839072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 710890 710890 0 0.0
.symtab 464528 464528 0 0.0
.text 1469748 1469748 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845280 845280 0 0.0
(read/write) 1604260 1604260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185668 185668 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1125898 1125898 0 0.0
.debug_aranges 127280 127280 0 0.0
.debug_frame 425568 425568 0 0.0
.debug_info 22321723 22321724 1 0.0
.debug_line 3522888 3522888 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1983899 1983899 0 0.0
.debug_rnglists 125202 125202 0 0.0
.debug_str 3787290 3787290 0 0.0
.heap 845280 845280 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 632498 632498 0 0.0
.symtab 429488 429488 0 0.0
.text 1407812 1407812 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 817848 817848 0 0.0
(read/write) 1634564 1634564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 213100 213100 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1102742 1102742 0 0.0
.debug_aranges 125224 125224 0 0.0
.debug_frame 418400 418400 0 0.0
.debug_info 21919914 21919914 0 0.0
.debug_line 3450730 3450730 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1951319 1951319 0 0.0
.debug_rnglists 122542 122542 0 0.0
.debug_str 3741525 3741525 0 0.0
.heap 817848 817848 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 602016 602016 0 0.0
.symtab 419328 419328 0 0.0
.text 1410684 1410684 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1175464 1175464 0 0.0
.bss 101336 101336 0 0.0
.data 788 788 0 0.0
.text 622304 622304 0 0.0
lock-app qpg6105+debug (read/write) 1132768 1132768 0 0.0
.bss 96056 96056 0 0.0
.data 792 792 0 0.0
.text 579612 579612 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1067736 1067736 0 0.0
bss 107348 107348 0 0.0
text 727146 727144 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 974196 974196 0 0.0
bss 105324 105324 0 0.0
text 667774 667772 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942016 942016 0 0.0
bss 109344 109344 0 0.0
text 645384 645384 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873904 873904 0 0.0
bss 99000 99000 0 0.0
text 588706 588706 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 902816 902808 -8 -0.0
bss 99564 99564 0 0.0
text 614358 614356 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980348 980348 0 0.0
bss 107676 107676 0 0.0
text 684224 684224 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 991720 991720 0 0.0
bss 111924 111924 0 0.0
text 691740 691738 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1049848 1049848 0 0.0
bss 109248 109248 0 0.0
text 729128 729128 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1081216 1081216 0 0.0
bss 120324 120324 0 0.0
text 749262 749262 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928468 928468 0 0.0
bss 99644 99644 0 0.0
text 616860 616860 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896544 896544 0 0.0
bss 100272 100272 0 0.0
text 610602 610602 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879416 879416 0 0.0
bss 99132 99132 0 0.0
text 594416 594416 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866556 866548 -8 -0.0
bss 98932 98932 0 0.0
text 584838 584836 -2 -0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744124 744132 8 0.0
bss 97256 97256 0 0.0
text 478572 478574 2 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875964 875964 0 0.0
bss 99088 99088 0 0.0
text 591766 591768 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 862680 862680 0 0.0
bss 98840 98840 0 0.0
text 580438 580438 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 908624 908624 0 0.0
bss 99384 99384 0 0.0
text 619880 619882 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 903976 903976 0 0.0
bss 99668 99668 0 0.0
text 614770 614770 0 0.0

@bzbarsky-apple
Refactor controller startup a bit to share more code.
b13a17b 
There was a lot of identical boilerplate between createControllerOnNewFabric and
createControllerOnExistingFabric.

checkIsRunning already sets error, which is why the setting of error if that
returns false was removed.
@github-actions
Copy link

github-actions bot commented Jul 29, 2023 •
edited
Loading

PR #28385: Size comparison from 2a681e3 to b13a17b

Increases (20 builds for bl602, bl702, bl702l, cc32xx, esp32, k32w, psoc6, telink)
platform target config section 2a681e3 b13a17b change % change
bl602 lighting-app bl602 .text 1055586 1055588 2 0.0
bl602+rpc .text 1087500 1087502 2 0.0
bl702 lighting-app bl702 (read/write) 1164599 1164603 4 0.0
.debug_info 41279389 41279390 1 0.0
.text 952252 952254 2 0.0
bl702l lighting-app bl702l .debug_info 41280498 41280499 1 0.0
.text 941314 941316 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19072471 19072472 1 0.0
esp32 all-clusters-app c3devkit (read/write) 1590048 1590056 8 0.0
.flash.rodata 219544 219552 8 0.0
k32w light k32w0+release (read only) 587340 587356 16 0.0
.text 586804 586820 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30038326 30038327 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27166572 27166573 1 0.0
lock cy8ckit_062s2_43012 .debug_info 21919913 21919914 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 667770 667772 2 0.0
bridge-app tlsr9518adk80d (read/write) 942008 942016 8 0.0
text 645380 645382 2 0.0
lighting-app-rpc tlsr9518adk80d text 729126 729128 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 896536 896544 8 0.0
text 610600 610604 4 0.0
pump-app tlsr9518adk80d text 594414 594418 4 0.0
pump-controller-app tlsr9518adk80d (read/write) 866548 866556 8 0.0
text 584836 584838 2 0.0
shell tlsr9518adk80d text 478574 478576 2 0.0
smoke_co_alarm-app tlsr9518adk80d text 591764 591766 2 0.0
temperature-measurement-app tlsr9518adk80d (read/write) 862672 862680 8 0.0
text 580436 580438 2 0.0
thermostat tlsr9518adk80d text 619880 619882 2 0.0
Decreases (7 builds for efr32, esp32, psoc6, telink)
platform target config section 2a681e3 b13a17b change % change
efr32 lighting-app BRD4187C (read/write) 1033564 1033556 -8 -0.0
.text 867004 866996 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1095536 1095534 -2 -0.0
.flash.text 1095536 1095534 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22321724 22321723 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 902816 902808 -8 -0.0
text 614358 614356 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 991728 991720 -8 -0.0
text 691742 691740 -2 -0.0
lock-app tlsr9518adk80d (read/write) 928476 928468 -8 -0.0
text 616862 616858 -4 -0.0
window-covering tlsr9518adk80d text 614772 614770 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2a681e3 b13a17b change % change
bl602 lighting-app bl602 (read/write) 1361970 1361970 0 0.0
.bss 73806 73806 0 0.0
.data 9608 9608 0 0.0
.text 1055586 1055588 2 0.0
bl602+rpc (read/write) 1409414 1409414 0 0.0
.bss 81846 81846 0 0.0
.data 10008 10008 0 0.0
.text 1087500 1087502 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1164599 1164603 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41237 41237 0 0.0
.bss_psram 43680 43680 0 0.0
.comment 48 48 0 0.0
.data 3600 3600 0 0.0
.debug_abbrev 1564080 1564080 0 0.0
.debug_aranges 140136 140136 0 0.0
.debug_frame 515452 515452 0 0.0
.debug_info 41279389 41279390 1 0.0
.debug_line 5469245 5469245 0 0.0
.debug_loc 3558169 3558169 0 0.0
.debug_ranges 384168 384168 0 0.0
.debug_str 4008650 4008650 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106096 106096 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 587740 587740 0 0.0
.symtab 175200 175200 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952252 952254 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1263467 1263467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49685 49685 0 0.0
.bss_psram 43680 43680 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1741255 1741255 0 0.0
.debug_aranges 148672 148672 0 0.0
.debug_frame 544320 544320 0 0.0
.debug_info 46152645 46152645 0 0.0
.debug_line 5881684 5881684 0 0.0
.debug_loc 3764132 3764132 0 0.0
.debug_ranges 409912 409912 0 0.0
.debug_str 4428504 4428504 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120748 120748 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 650703 650703 0 0.0
.symtab 194128 194128 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1026916 1026916 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1150424 1150424 0 0.0
.boot2 292 292 0 0.0
.bss 15924 15924 0 0.0
.bss_psram 78096 78096 0 0.0
.comment 48 48 0 0.0
.data 4568 4568 0 0.0
.debug_abbrev 1566299 1566299 0 0.0
.debug_aranges 134640 134640 0 0.0
.debug_frame 495140 495140 0 0.0
.debug_info 41280498 41280499 1 0.0
.debug_line 5384813 5384813 0 0.0
.debug_loc 3494338 3494338 0 0.0
.debug_ranges 389376 389376 0 0.0
.debug_str 4021107 4021107 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 140 140 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99980 99980 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 587965 587965 0 0.0
.symtab 174768 174768 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
941314 941316 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 610370 610370 0 0.0
(read/write) 208284 208284 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201696 201696 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 947836 947836 0 0.0
.debug_aranges 108032 108032 0 0.0
.debug_frame 366676 366676 0 0.0
.debug_info 19072471 19072472 1 0.0
.debug_line 2783805 2783805 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1581595 1581595 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 99685 99685 0 0.0
.debug_str 3416700 3416700 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105250 105250 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 490115 490115 0 0.0
.symtab 290064 290064 0 0.0
.text 502996 502996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 548927 548927 0 0.0
.app_xip_area 440017 440017 0 0.0
.bss 63880 63880 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 533255 533255 0 0.0
.app_xip_area 419385 419385 0 0.0
.bss 68832 68832 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571927 571927 0 0.0
.app_xip_area 464105 464105 0 0.0
.bss 62840 62840 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 545367 545367 0 0.0
.app_xip_area 434577 434577 0 0.0
.bss 65728 65728 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008628 1008628 0 0.0
.bss 183636 183636 0 0.0
.data 2692 2692 0 0.0
.text 822280 822280 0 0.0
BRD4187C (read/write) 1033564 1033556 -8 -0.0
.bss 163252 163252 0 0.0
.data 3288 3288 0 0.0
.text 867004 866996 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1083616 1083616 0 0.0
.bss 177652 177652 0 0.0
.data 2688 2688 0 0.0
.text 903256 903256 0 0.0
window-app BRD4187C (read/write) 1104604 1104604 0 0.0
.bss 146244 146244 0 0.0
.data 3200 3200 0 0.0
.text 955140 955140 0 0.0
esp32 all-clusters-app c3devkit (read only) 1095536 1095534 -2 -0.0
(read/write) 1590048 1590056 8 0.0
.dram0.bss 77368 77368 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 219544 219552 8 0.0
.flash.text 1095536 1095534 -2 -0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1141887 1141887 0 0.0
(read/write) 500434 500434 0 0.0
.dram0.bss 82848 82848 0 0.0
.dram0.data 34344 34344 0 0.0
.flash.rodata 248092 248092 0 0.0
.flash.text 1136503 1136503 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 588668 588668 0 0.0
(read/write) 91480 91480 0 0.0
.bss 67476 67476 0 0.0
.data 2168 2168 0 0.0
.text 588132 588132 0 0.0
light k32w0+release (read only) 587340 587356 16 0.0
(read/write) 91112 91112 0 0.0
.bss 67124 67124 0 0.0
.data 2156 2156 0 0.0
.text 586804 586820 16 0.0
lock k32w0+release (read only) 559900 559900 0 0.0
(read/write) 88936 88936 0 0.0
.bss 65012 65012 0 0.0
.data 2100 2100 0 0.0
.text 559364 559364 0 0.0
linux all-clusters-app debug (read only) 5478993 5478993 0 0.0
(read/write) 417264 417264 0 0.0
.bss 129920 129920 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 275584 275584 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 332816 332816 0 0.0
.text 4769555 4769555 0 0.0
all-clusters-minimal-app debug (read only) 4894073 4894073 0 0.0
(read/write) 231280 231280 0 0.0
.bss 125600 125600 0 0.0
.data 4304 4304 0 0.0
.data.rel.ro 94248 94248 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 270918 270918 0 0.0
.text 4393171 4393171 0 0.0
bridge-app debug (read only) 2763233 2763233 0 0.0
(read/write) 132936 132936 0 0.0
.bss 50680 50680 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 71272 71272 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 213480 213480 0 0.0
.text 2372419 2372419 0 0.0
chip-tool debug (read only) 17752889 17752889 0 0.0
(read/write) 1054936 1054936 0 0.0
.bss 93592 93592 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 948848 948848 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 914537 914537 0 0.0
.text 14783539 14783539 0 0.0
chip-tool-ipv6only arm64 (read only) 16968124 16968124 0 0.0
(read/write) 1122488 1122488 0 0.0
.bss 102984 102984 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 986224 986224 0 0.0
.dynamic 512 512 0 0.0
.got 23344 23344 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 825848 825848 0 0.0
.text 13902824 13902824 0 0.0
lighting-app debug+rpc+ui (read only) 5272137 5272137 0 0.0
(read/write) 222184 222184 0 0.0
.bss 117616 117616 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 92112 92112 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337524 337524 0 0.0
.text 4692707 4692707 0 0.0
lock-app debug (read only) 4451681 4451681 0 0.0
(read/write) 202120 202120 0 0.0
.bss 112944 112944 0 0.0
.data 4048 4048 0 0.0
.data.rel.ro 78368 78368 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 246150 246150 0 0.0
.text 3997187 3997187 0 0.0
ota-provider-app debug (read only) 4121849 4121849 0 0.0
(read/write) 191992 191992 0 0.0
.bss 113504 113504 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 68320 68320 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 199942 199942 0 0.0
.text 3731779 3731779 0 0.0
ota-requestor-app debug (read only) 4215841 4215841 0 0.0
(read/write) 196304 196304 0 0.0
.bss 114432 114432 0 0.0
.data 4624 4624 0 0.0
.data.rel.ro 71320 71320 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 203430 203430 0 0.0
.text 3817955 3817955 0 0.0
shell debug (read only) 2922305 2922305 0 0.0
(read/write) 150616 150616 0 0.0
.bss 59592 59592 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 83896 83896 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 208786 208786 0 0.0
.text 2542818 2542818 0 0.0
thermostat-no-ble arm64 (read only) 4445156 4445156 0 0.0
(read/write) 243992 243992 0 0.0
.bss 122200 122200 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 102168 102168 0 0.0
.dynamic 512 512 0 0.0
.got 11960 11960 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161324 161324 0 0.0
.text 3945976 3945976 0 0.0
tv-app debug (read only) 5309297 5309297 0 0.0
(read/write) 349944 349944 0 0.0
.bss 240416 240416 0 0.0
.data 6224 6224 0 0.0
.data.rel.ro 95904 95904 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 271446 271446 0 0.0
.text 4794403 4794403 0 0.0
tv-casting-app debug (read only) 8287153 8287153 0 0.0
(read/write) 210528 210528 0 0.0
.bss 54112 54112 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 146712 146712 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 366492 366492 0 0.0
.text 7521075 7521075 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2517080 2517080 0 0.0
.bss 220432 220432 0 0.0
.data 5152 5152 0 0.0
.text 1479764 1479764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1216456 1216456 0 0.0
bss 154659 154659 0 0.0
rodata 140668 140668 0 0.0
text 842000 842000 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1335756 1335756 0 0.0
bss 140117 140117 0 0.0
rodata 135188 135188 0 0.0
text 769664 769664 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1154372 1154372 0 0.0
bss 154838 154838 0 0.0
rodata 112056 112056 0 0.0
text 808444 808444 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837120 837120 0 0.0
(read/write) 1764940 1764940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193596 193596 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2624 2624 0 0.0
.debug_abbrev 1376055 1376055 0 0.0
.debug_aranges 143504 143504 0 0.0
.debug_frame 478148 478148 0 0.0
.debug_info 30038326 30038327 1 0.0
.debug_line 4133056 4133056 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2241517 2241517 0 0.0
.debug_rnglists 142019 142019 0 0.0
.debug_str 4114532 4114532 0 0.0
.heap 837120 837120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 800233 800233 0 0.0
.symtab 498864 498864 0 0.0
.text 1560332 1560332 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839072 839072 0 0.0
(read/write) 1672404 1672404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191708 191708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1285416 1285416 0 0.0
.debug_aranges 137008 137008 0 0.0
.debug_frame 461936 461936 0 0.0
.debug_info 27166572 27166573 1 0.0
.debug_line 3956018 3956018 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2144678 2144678 0 0.0
.debug_rnglists 135312 135312 0 0.0
.debug_str 3976139 3976139 0 0.0
.heap 839072 839072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 710890 710890 0 0.0
.symtab 464528 464528 0 0.0
.text 1469748 1469748 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845280 845280 0 0.0
(read/write) 1604260 1604260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185668 185668 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1125898 1125898 0 0.0
.debug_aranges 127280 127280 0 0.0
.debug_frame 425568 425568 0 0.0
.debug_info 22321724 22321723 -1 -0.0
.debug_line 3522888 3522888 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1983899 1983899 0 0.0
.debug_rnglists 125202 125202 0 0.0
.debug_str 3787290 3787290 0 0.0
.heap 845280 845280 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 632498 632498 0 0.0
.symtab 429488 429488 0 0.0
.text 1407812 1407812 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 817848 817848 0 0.0
(read/write) 1634564 1634564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 213100 213100 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1102742 1102742 0 0.0
.debug_aranges 125224 125224 0 0.0
.debug_frame 418400 418400 0 0.0
.debug_info 21919913 21919914 1 0.0
.debug_line 3450730 3450730 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1951319 1951319 0 0.0
.debug_rnglists 122542 122542 0 0.0
.debug_str 3741525 3741525 0 0.0
.heap 817848 817848 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 602016 602016 0 0.0
.symtab 419328 419328 0 0.0
.text 1410684 1410684 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1175464 1175464 0 0.0
.bss 101336 101336 0 0.0
.data 788 788 0 0.0
.text 622304 622304 0 0.0
lock-app qpg6105+debug (read/write) 1132768 1132768 0 0.0
.bss 96056 96056 0 0.0
.data 792 792 0 0.0
.text 579612 579612 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1067736 1067736 0 0.0
bss 107348 107348 0 0.0
text 727144 727144 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 974196 974196 0 0.0
bss 105324 105324 0 0.0
text 667770 667772 2 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942008 942016 8 0.0
bss 109344 109344 0 0.0
text 645380 645382 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873904 873904 0 0.0
bss 99000 99000 0 0.0
text 588706 588706 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 902816 902808 -8 -0.0
bss 99564 99564 0 0.0
text 614358 614356 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980348 980348 0 0.0
bss 107676 107676 0 0.0
text 684224 684224 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 991728 991720 -8 -0.0
bss 111924 111924 0 0.0
text 691742 691740 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1049848 1049848 0 0.0
bss 109248 109248 0 0.0
text 729126 729128 2 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1081216 1081216 0 0.0
bss 120324 120324 0 0.0
text 749262 749262 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928476 928468 -8 -0.0
bss 99644 99644 0 0.0
text 616862 616858 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896536 896544 8 0.0
bss 100272 100272 0 0.0
text 610600 610604 4 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879416 879416 0 0.0
bss 99132 99132 0 0.0
text 594414 594418 4 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866548 866556 8 0.0
bss 98932 98932 0 0.0
text 584836 584838 2 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744132 744132 0 0.0
bss 97256 97256 0 0.0
text 478574 478576 2 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875964 875964 0 0.0
bss 99088 99088 0 0.0
text 591764 591766 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 862672 862680 8 0.0
bss 98840 98840 0 0.0
text 580436 580438 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 908624 908624 0 0.0
bss 99384 99384 0 0.0
text 619880 619882 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 903976 903976 0 0.0
bss 99668 99668 0 0.0
text 614772 614770 -2 -0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@mergify mergify bot merged commit 693ef72 into project-chip:master Jul 29, 2023
@bzbarsky-apple bzbarsky-apple deleted the share-startup-code branch July 30, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @jtung-apple