-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GroupKeyMulticastPolicy
to GroupKeySetStruct in group key management cluster
#28382
Closed
andy31415
wants to merge
3
commits into
project-chip:master
from
andy31415:add_enums_to_group_cluster
Closed
Add GroupKeyMulticastPolicy
to GroupKeySetStruct in group key management cluster
#28382
andy31415
wants to merge
3
commits into
project-chip:master
from
andy31415:add_enums_to_group_cluster
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
July 28, 2023 21:01
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
July 28, 2023 21:01
pullapprove
bot
added
review - pending
examples
darwin
controller
app
tests
and removed
examples
darwin
controller
app
tests
labels
Jul 28, 2023
tcarmelveilleux
approved these changes
Jul 28, 2023
@@ -40,14 +57,9 @@ limitations under the License. | |||
<item fieldId="5" name="EpochStartTime1" type="epoch_us" isNullable="true"/> | |||
<item fieldId="6" name="EpochKey2" type="OCTET_STRING" length="16" isNullable="true"/> | |||
<item fieldId="7" name="EpochStartTime2" type="epoch_us" isNullable="true"/> | |||
<item fieldId="8" name="GroupKeyMulticastPolicy" type="GroupKeyMulticastPolicyEnum" isNullable="false"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must make this optional and treat it as value 0. Otherwise we break all existing clients.
PR #28382: Size comparison from 7baabb7 to 16c27ec Increases (55 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Closing - this requires different changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new member, define the enum, update unit test to default to 0.
Add a featuremap bitmap.
Fixes subset of #25642 (adds struct member and defines feature)