-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Add nvs size to 48k bytes in examples for matter 1.1 #28353
Merged
mergify
merged 1 commit into
project-chip:master
from
Jerry-ESP:esp32/add_nvs_size_for_matter1_1
Jul 31, 2023
Merged
[ESP32] Add nvs size to 48k bytes in examples for matter 1.1 #28353
mergify
merged 1 commit into
project-chip:master
from
Jerry-ESP:esp32/add_nvs_size_for_matter1_1
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry-ESP
changed the title
[ESP32] add nvs size to 48k bytes in examples for matter 1.1
[ESP32] Add nvs size to 48k bytes in examples for matter 1.1
Jul 28, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
July 28, 2023 06:21
pullapprove
bot
requested review from
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
July 28, 2023 06:21
PR #28353: Size comparison from 6e9b15c to dbb7cd7 Increases (16 builds for bl602, bl702, bl702l, cyw30739, psoc6, telink)
Decreases (7 builds for nrfconnect, telink)
Full report (54 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Jerry-ESP
force-pushed
the
esp32/add_nvs_size_for_matter1_1
branch
from
July 28, 2023 11:12
dbb7cd7
to
f475f90
Compare
PR #28353: Size comparison from 97964db to f475f90 Increases (7 builds for bl702, cyw30739, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 28, 2023
andy31415
approved these changes
Jul 28, 2023
Jerry-ESP
force-pushed
the
esp32/add_nvs_size_for_matter1_1
branch
from
July 31, 2023 05:14
f475f90
to
508d46f
Compare
PR #28353: Size comparison from 693ef72 to 508d46f Increases (4 builds for bl702l, esp32, psoc6)
Decreases (4 builds for bl602, cc32xx, efr32, psoc6)
Full report (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Jerry-ESP
force-pushed
the
esp32/add_nvs_size_for_matter1_1
branch
from
July 31, 2023 06:54
508d46f
to
b9e6c9c
Compare
PR #28353: Size comparison from 693ef72 to b9e6c9c Increases (11 builds for esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702l, cc32xx, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@Jerry-ESP Please cherry-pick this to v1.1-branch |
Jerry-ESP
added a commit
to Jerry-ESP/connectedhomeip
that referenced
this pull request
Jul 31, 2023
andy31415
added a commit
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The default 24k nvs size is not enough for matter 1.1 TC-RR-1.1 test
Changes
Change all the examples's default nvs size to 48k
Testing
Has tested on lighting-app and all-clusters-app examples