-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: Update esp-idf to v5.1 and remove few pinned package version #28333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shubhamdp
commented
Jul 27, 2023
•
edited
Loading
edited
- esp-idf v5.1 was released sometime back so, updating to the latest stable release
- Few of the pinned packages in docker file was not found when building them, removed the pinned versions from them. ( please check failures for efr32, nrf, telink, openiotsdk)
- efr32: gcc-arm-none-eabi, binutils-arm-none-eabi, ccache
- telink: gcc-multilib, g++-multilib, libsdl2-dev, ccache, device-tree-compiler
- nrf: device-tree-compiler
- openiotsdk: wget
Removing the pinned versions for packages for below platforms - efr32: ccache - nrf: device-tree-compiler - openiotsdk: wget - telink: ccache, device-tree-compiler
- efr32: gcc-arm-none-eabi, binutils-arm-none-eabi - telink: gcc-multilib, g++-multilib, libsdl2-dev
PR #28333: Size comparison from 2b76339 to 2981be7 Increases (11 builds for bl702, bl702l, cyw30739, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, bl702, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
July 28, 2023 03:48
pullapprove
bot
requested review from
mkardous-silabs,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 28, 2023 03:48
Damian-Nordic
approved these changes
Jul 28, 2023
shubhamdp
commented
Jul 28, 2023
andy31415
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.