-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Allowing empty semantic tags list in SupportedModes attribute of ModeSelect #28324
Merged
mergify
merged 2 commits into
project-chip:master
from
jadhavrohit924:bugfix-mode-select
Jul 28, 2023
Merged
[ESP32] Allowing empty semantic tags list in SupportedModes attribute of ModeSelect #28324
mergify
merged 2 commits into
project-chip:master
from
jadhavrohit924:bugfix-mode-select
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Jul 27, 2023
- Problem
- Changes
- Testing
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
July 27, 2023 10:30
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 27, 2023 10:30
PR #28324: Size comparison from d2b1ea8 to 2e67126 Increases (9 builds for bl702, psoc6, telink)
Decreases (13 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jadhavrohit924
force-pushed
the
bugfix-mode-select
branch
from
July 27, 2023 14:38
2e67126
to
64e3ce7
Compare
PR #28324: Size comparison from 0a7cc29 to 64e3ce7 Increases (5 builds for nrfconnect, psoc6, telink)
Decreases (21 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 27, 2023
jadhavrohit924
force-pushed
the
bugfix-mode-select
branch
from
July 28, 2023 04:31
64e3ce7
to
c024ea1
Compare
dhrishi
approved these changes
Jul 28, 2023
PR #28324: Size comparison from 6e9b15c to c024ea1 Increases (15 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Decreases (6 builds for efr32, esp32, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.