Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable EventList attribute in yaml tests and code #28299

Merged
merged 24 commits into from
Jul 28, 2023
Merged

Disable EventList attribute in yaml tests and code #28299

Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ca5180a
Add pics to all EventList reads
andreilitvin Jul 25, 2023
2449fcd
Update AttributeList validation based on event list enabled pics
andreilitvin Jul 25, 2023
8cdd5e1
Define the pics
andreilitvin Jul 25, 2023
571235e
zap regen
andreilitvin Jul 25, 2023
5f63f8a
Restyle
andreilitvin Jul 25, 2023
5f43313
Update ci-pics-values
andy31415 Jul 26, 2023
c7f7522
Enable PICS event list to pass CI. Separate PR to disable the pics an…
andy31415 Jul 26, 2023
15df6b4
Mark PICS EVENT LIST attribute disabled
andy31415 Jul 26, 2023
5217ee4
Mass-disable eventlist server-side attribute in zap
andy31415 Jul 26, 2023
136f507
Zap regen: shows eventlist attribute gone at least from .matter files
andy31415 Jul 26, 2023
5abc671
Disable eventlist attribute from build config
andy31415 Jul 26, 2023
13659bc
Fix test constants ... but this does not exactly explain the content :(
andy31415 Jul 26, 2023
d1a68dd
Adjust comment
andy31415 Jul 26, 2023
1679f5b
Merge branch 'master' into disable_eventlist_attribute
andy31415 Jul 26, 2023
d1616b6
Merge branch 'master' into disable_eventlist_attribute
andy31415 Jul 27, 2023
2556578
zap regen
andy31415 Jul 27, 2023
77be267
Add more comments regarding chunking...this logic is odd though
andy31415 Jul 27, 2023
94f3b69
Merge branch 'master' into disable_eventlist_attribute
andreilitvin Jul 28, 2023
04a8826
Update src/app/tests/TestReadInteraction.cpp
andy31415 Jul 28, 2023
e75858a
Update src/app/tests/TestReadInteraction.cpp
andy31415 Jul 28, 2023
b668d34
Update src/app/tests/TestReadInteraction.cpp
andy31415 Jul 28, 2023
526d95c
Update src/app/tests/TestReadInteraction.cpp
andy31415 Jul 28, 2023
25fb008
Update src/app/tests/TestReadInteraction.cpp
andy31415 Jul 28, 2023
40f1277
Restyled by whitespace
restyled-commits Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/app/tests/TestReadInteraction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,6 +1938,7 @@ void TestReadInteraction::TestSubscribeWildcard(nlTestSuite * apSuite, void * ap

NL_TEST_ASSERT(apSuite, delegate.mGotReport);

#if CHIP_CONFIG_ENABLE_EVENTLIST_ATTRIBUTE
// We have 29 attributes in our mock attribute storage. And we subscribed twice.
// And attribute 3/2/4 is a list with 6 elements and list chunking is
// applied to it, but the way the packet boundaries fall we get two of
Expand All @@ -1946,7 +1947,12 @@ void TestReadInteraction::TestSubscribeWildcard(nlTestSuite * apSuite, void * ap
// items for the other.
//
// Thus we should receive 29*2 + 4 + 3 = 65 attribute data in total.
NL_TEST_ASSERT(apSuite, delegate.mNumAttributeResponse == 65);
constexpr size_t kExpectedAttributeResponse = 65;
#else
// Receiving 29*2 + 4 + 6 = 68 when eventlist attribute is not available.
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
constexpr size_t kExpectedAttributeResponse = 68;
#endif
NL_TEST_ASSERT(apSuite, delegate.mNumAttributeResponse == kExpectedAttributeResponse);
NL_TEST_ASSERT(apSuite, delegate.mNumArrayItems == 12);
NL_TEST_ASSERT(apSuite, engine->GetNumActiveReadHandlers(ReadHandler::InteractionType::Subscribe) == 1);
NL_TEST_ASSERT(apSuite, engine->ActiveHandlerAt(0) != nullptr);
Expand Down