-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Apply 'AppDelegate' for android app server #28286
Merged
saurabhst
merged 6 commits into
project-chip:master
from
chulspro:feature/contribution-virtual-device-app
Jul 27, 2023
Merged
[Android] Apply 'AppDelegate' for android app server #28286
saurabhst
merged 6 commits into
project-chip:master
from
chulspro:feature/contribution-virtual-device-app
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chulspro
requested review from
tcarmelveilleux,
saurabhst,
andy31415,
arkq and
electrocucaracha
July 26, 2023 04:19
chulspro
force-pushed
the
feature/contribution-virtual-device-app
branch
from
July 26, 2023 04:25
b6380fe
to
64dd476
Compare
PR #28286: Size comparison from 9c90f0f to 64dd476 Increases (9 builds for bl602, bl702, bl702l, cc32xx, nrfconnect, qpg, telink)
Decreases (7 builds for efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
cliffamzn,
Damian-Nordic,
dhrishi,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
July 26, 2023 08:41
pullapprove
bot
requested review from
robszewczyk,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 26, 2023 08:41
PR #28286: Size comparison from 9c90f0f to 9c93bf1 Increases (9 builds for bl602, cc32xx, linux, nrfconnect, qpg, telink)
Decreases (7 builds for bl702, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chulspro
force-pushed
the
feature/contribution-virtual-device-app
branch
from
July 27, 2023 02:22
9c93bf1
to
883caef
Compare
PR #28286: Size comparison from 426be96 to 883caef Increases (3 builds for bl702, nrfconnect)
Decreases (1 build for bl602)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
* Add 'starAppWithDelegate' api * Add 'ChipAppServerDelegate' interface Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
chulspro
force-pushed
the
feature/contribution-virtual-device-app
branch
from
July 27, 2023 02:58
883caef
to
a848b9d
Compare
PR #28286: Size comparison from 426be96 to a848b9d Increases (6 builds for bl702, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 27, 2023
saurabhst
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing