-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding resource-monitoring-instances.cpp
to all-clusters-app on non-linux platforms
#28205
Merged
mergify
merged 3 commits into
project-chip:master
from
tobiasgraf:Adding_resource-monitoring-instances_to_all-clusters-app_on_non-linux_platforms
Jul 24, 2023
Merged
Adding resource-monitoring-instances.cpp
to all-clusters-app on non-linux platforms
#28205
mergify
merged 3 commits into
project-chip:master
from
tobiasgraf:Adding_resource-monitoring-instances_to_all-clusters-app_on_non-linux_platforms
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
July 24, 2023 10:00
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 24, 2023 10:00
mhazley
approved these changes
Jul 24, 2023
ericzijian1994
approved these changes
Jul 24, 2023
p0fi
approved these changes
Jul 24, 2023
tobiasgraf
deleted the
Adding_resource-monitoring-instances_to_all-clusters-app_on_non-linux_platforms
branch
July 24, 2023 11:59
PR #28205: Size comparison from c1ec2d7 to 064036e Increases above 0.2%:
Increases (17 builds for esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (17 builds for bl602, bl702, bl702l, esp32, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
resource-monitoring-instances.cpp
(which implements the reset-condition command callbacks) to the non-linux platforms' all-clusters-app:ameba
asr
cc13x2x7_26x2x7
cc13x4_26x4
infineon
mbed
nrfconnect
nxp
openiotsdk
telink
tizen