-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced the use of std::set with IntrusiveList in ModeBase. #28163
Merged
mergify
merged 15 commits into
project-chip:master
from
dysonltd:ReplaceSetWithIntrusivListInModeBase
Jul 25, 2023
Merged
Replaced the use of std::set with IntrusiveList in ModeBase. #28163
mergify
merged 15 commits into
project-chip:master
from
dysonltd:ReplaceSetWithIntrusivListInModeBase
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
aronrosenberg,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
July 21, 2023 13:46
bzbarsky-apple
approved these changes
Jul 21, 2023
…used it in the linux all-clusters-app.
PR #28163: Size comparison from 484dcd8 to 8c984f9 Increases (13 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for efr32, nrfconnect, psoc6, telink)
Full report (47 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28163: Size comparison from d328c30 to 62097db Increases (16 builds for bl702, cc32xx, linux, psoc6, telink)
Decreases (16 builds for cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 24, 2023
examples/all-clusters-app/all-clusters-common/src/dishwasher-mode.cpp
Outdated
Show resolved
Hide resolved
…led twice and properly free the memory.
Co-authored-by: Boris Zbarsky <[email protected]>
PR #28163: Size comparison from 3efdd36 to fb72bcf Increases (23 builds for bl602, bl702, bl702l, cyw30739, linux, psoc6, telink)
Decreases (10 builds for linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
p0fi
approved these changes
Jul 25, 2023
cliffamzn
pushed a commit
to cliffamzn/connectedhomeip
that referenced
this pull request
Jul 25, 2023
…-chip#28163) * Replaced the use of std::set with IntrusiveList in ModeBase. * Removed the std::set exeption for ModeBase. * Restyled by clang-format * Refoctor from review. * Added a way to gracefully shutdown the ModeBase dreived clusters and used it in the linux all-clusters-app. * Restyled by whitespace * Restyled by clang-format * Implemented required ApplicationExit(). * Restyled by clang-format * Modified the ModeBase example shutdowns to be safe if Shutdown is called twice and properly free the memory. * Renamed ApplicationExit() to ApplicationShutdown() * Apply documentation suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28125 Replaces the use of
std::set
withIntrusiveList
.