-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BouffaloLab]Add generate factory qr code scripts #28146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
aronrosenberg,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
July 21, 2023 02:52
pullapprove
bot
requested review from
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
plauric,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
July 21, 2023 02:52
woody-apple
approved these changes
Jul 21, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 9, 2023
project-chip#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 9, 2023
project-chip#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 9, 2023
project-chip#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in. The action fixes are to make sure that for boufallolab CI we end up doing bootstrap with the right -p parameter to pull in requirements.bouffalolab.txt there.
andy31415
pushed a commit
that referenced
this pull request
Aug 9, 2023
#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in. The action fixes are to make sure that for boufallolab CI we end up doing bootstrap with the right -p parameter to pull in requirements.bouffalolab.txt there.
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
project-chip#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in. The action fixes are to make sure that for boufallolab CI we end up doing bootstrap with the right -p parameter to pull in requirements.bouffalolab.txt there.
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
project-chip#28146 added bitarray to requirements.bouffalolab.txt, but that package requires native compilation during bootstrap. And bootstrap ends up using the pigweed-provided clang for that, but that clang is broken on M1/M2 mac. For now, stop pulling requirements.bouffalolab.txt into the general requirements.all.txt, so that bootstrap works for all the people not actively developing for bouffalolab. If it's re-added there later, it should be split up to make sure the bitarray bits are not pulled in. The action fixes are to make sure that for boufallolab CI we end up doing bootstrap with the right -p parameter to pull in requirements.bouffalolab.txt there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BouffaloLab] Add generate factory qr code scripts