Revert "Cancel incomplete BLE connection when CloseAllBleConnections() is called (#27304)"

[bzbarsky-apple]

This reverts commit ad5403e.

There are two issues:

• [BUG] CHIP Error 0x00000003: Incorrect state when paring device with chip-tool #27607 which has had no response for weeks.
• [BUG] Unable to pair M5 board / nordic using chip tool #28139 which breaks commissioning on Mac, and would break it on Linux if it implemented BLE connection cancellation.

We need to sort out why CHIPDeviceController is canceling BLE connections when starting PASE over BLE (!).

Fixes #28139

[woody-apple]

@bzbarsky-apple The change makes logical sense though, to cancel any connections being established though? Why is this causing issues?

[bzbarsky-apple]

@woody-apple Because of this stack:

  * frame #0: 0x0000000101bf916c chip-tool`chip::Ble::BleLayer::CancelBleIncompleteConnection(this=0x0000000102beb5a0) at BleLayer.cpp:372:5
    frame #1: 0x0000000101bf8cd4 chip-tool`chip::Ble::BleLayer::CloseAllBleConnections(this=0x0000000102beb5a0) at BleLayer.cpp:312:22
    frame #2: 0x0000000102260b80 chip-tool`chip::Controller::DeviceCommissioner::ReleaseCommissioneeDevice(this=0x0000000108d11900, device=0x0000000107915e80) at CHIPDeviceController.cpp:560:35
    frame #3: 0x0000000102265d64 chip-tool`chip::Controller::DeviceCommissioner::OnDiscoveredDeviceOverBleSuccess(appState=0x0000000108d11900, connObj=0x000000010bf953c0) at CHIPDeviceController.cpp:795:15

Now why we end up doing CloseAllBleConnections from establishing a BLE connection I don't know, but until we stop doing that, we can't cancel the actual connection that got established from there.... For now this gets us back to the known-good state we were in since 1.0. Once we figure out what's going on with that bit and the shutdown issues #27607 describes, we can put this back.

[vivien-apple]

I think we should revert as you suggest. The original patch may probably be retargeted to call mSystemState->BleLayer()->CancelBleIncompleteConnection(); in DeviceCommissioner::OnSessionEstablishmentError.

Something like:

void DeviceCommissioner::OnSessionEstablishmentError(CHIP_ERROR err)
{
   ...
   if (mPairingDelegate != nullptr)
   {
        mPairingDelegate->OnStatusUpdate(DevicePairingDelegate::SecurePairingFailed);
    }

    auto device = self->mDeviceInPASEEstablishment;
    if (nullptr != device && device->GetDeviceTransportType() == Transport::Type::kBle)
    {
        mSystemState->BleLayer()->CancelBleIncompleteConnection();
    }

    RendezvousCleanup(err);
}