Power source: Update bridge app #28134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move power cluster to composed endpoint base
- add power source device type to composed endpoint base
- add endpoint list to power source cluster
- update revision of power source cluster
- Use AttributeAccess interface (allows list handling)
- Add required attributes
NOTE: The events list is still not correct, so the bridge app
does not pass the 1.1 test
Tests: Attributes ok on 1.1, 2.1 ok
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Jul 20, 2023
Test: Read EndpointList attribute from correct and incorrect cluster
TC_PS_1_1, TC_PS_2_1 (1.1 fails, but not on attributes)
also tried with empty endpoint list - OK
cecille
force-pushed
the
power_source_bridge_app
branch
from
21086c3 to
c5fb3fd
Compare
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
cliffamzn
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The events list is still not correct, so the bridge app
does not pass the 1.1 test
Tests: Attributes ok on 1.1, events fail, 2.1 ok