Revert "[app] Add option to disable Read Client" #28087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a48afe0.
pullapprove
bot
requested review from
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
LuDuda,
mhazley,
mrjerryjohns,
msandstedt,
nivi-apple,
p0fi,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
@wqx6 FYI |
|
In particular, ReadClient is used from various code that was not made conditional in #28050. Ideally, setting that compile option would remove the definition of the ReadClient class altogether (e.g. via ifdefs in that header, so the includes don't have to be ifdefed), and then fix all the resulting compile failures. |
|
Thanks for suggestion, I will raise another PR. |
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28050
this doesn’t compile in the opposite path, please redo this, and add tests to confirm both paths.