[ReadHandler] Synchronized report scheduler #27943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behavior on the scheduler with up to 4 ReadHandlers as well logging mechanism to find out what handler fires at what time.
…doesn't belong here
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
lpbeliveau-silabs
force-pushed
the
feature/synchronized_report_scheduler
branch
from
66d6ab5 to
35f7d41
Compare
… dynamical memory allocation
jmartinez-silabs
approved these changes
Jul 18, 2023
bzbarsky-apple
approved these changes
Jul 19, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
…s and added doc on unclear behavior
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Added a Synchronized ReportScheduler along with test to confirm the behavior on the scheduler with up to 4 ReadHandlers as well logging mechanism to find out what handler fires at what time. * Added a quick fix because TestDecoding won't compile otherwise, this doesn't belong here * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Refactored ReportScheduler Impls to better take advantage of inheritance, removed bloat, excluded test for platform in which problems are caused due to unprocessed engine runs * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Applied comment review and refactoed next timeout calculation logic * Completed unit test and logic * Passing a ReportSchedulerPointer instead of an std::function to avoid dynamical memory allocation * undid ReadHandler changes * Update src/app/reporting/ReportScheduler.h Co-authored-by: Boris Zbarsky <[email protected]> * Removed un-necessary nullptr check, addressed comments regarding tests and added doc on unclear behavior * Addressed redundant test --------- Co-authored-by: Boris Zbarsky <[email protected]>
doru91
added a commit
to NXP/matter
that referenced
this pull request
Aug 4, 2023
Introduced by upstream PR project-chip#27943. Signed-off-by: Doru Gucea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Synchronised Implementation of the Report Scheduler to reduce the number of time a device would have to wake up to emit reports by making all handlers emit reports at the same wake event if they are above their minimal interval.
Tested in TestReportScheduler for up to 4 handlers to confirm logic.