-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Map wifi_auth_mode_t to NetworkCommissioning Security #27929
Merged
mergify
merged 2 commits into
project-chip:master
from
wqx6:esp32/map_authmode_to_security
Jul 18, 2023
Merged
ESP32: Map wifi_auth_mode_t to NetworkCommissioning Security #27929
mergify
merged 2 commits into
project-chip:master
from
wqx6:esp32/map_authmode_to_security
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 13, 2023 02:47
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
p0fi,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
July 13, 2023 02:47
bzbarsky-apple
approved these changes
Jul 13, 2023
PR #27929: Size comparison from 5d2beb7 to 7864032 Increases (10 builds for bl602, cc32xx, esp32, psoc6, telink)
Decreases (11 builds for bl702, bl702l, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27929: Size comparison from 01116da to 7b4343b Increases (6 builds for bl602, bl702, cc32xx, nrfconnect, psoc6)
Decreases (2 builds for k32w, psoc6)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
woody-apple
approved these changes
Jul 18, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetworkCommissioning Scanning result security doesn't match the SPEC on ESP32. Add a function of mapping wifi_auth_mode_t to NetworkCommissioning Security.