Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Fan PercentSetting floating point precision error after "ceil()" #27912

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Workaround Fan PercentSetting floating point precision error after "ceil()" #27912

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90810fe
Workaround Fan Percent Setting floating point err
erwinpan1 Jul 12, 2023
0040b88
Restyled by clang-format
restyled-commits Jul 12, 2023
fdc74b5
Workaround Fan PercentSetting float error (2nd)
erwinpan1 Jul 13, 2023
66262a3
Update src/app/clusters/fan-control-server/fan-control-server.cpp
andy31415 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/app/clusters/fan-control-server/fan-control-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,9 @@ void MatterFanControlClusterServerAttributeChangedCallback(const app::ConcreteAt
VerifyOrReturn(EMBER_ZCL_STATUS_SUCCESS == status,
ChipLogError(Zcl, "Failed to get SpeedSetting with error: 0x%02x", status));

float percent = percentSetting.Value();
uint8_t speedSetting = static_cast<uint8_t>(ceil(speedMax * (percent * 0.01)));
uint16_t percent = percentSetting.Value();
// Plus 99 then devide by 100 instead of multiplying 0.01 to workaround floating point precision error
uint8_t speedSetting = static_cast<uint8_t>(ceil((speedMax * percent + 99) / 100));
andy31415 marked this conversation as resolved.
Show resolved Hide resolved

if (currentSpeedSetting.IsNull() || speedSetting != currentSpeedSetting.Value())
{
Expand Down