-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[other] Add to flake8 in workflow and fix python files (part #25193) #27890
Merged
mergify
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-other-python-files
Jul 12, 2023
Merged
[other] Add to flake8 in workflow and fix python files (part #25193) #27890
mergify
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-other-python-files
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
tools
examples
setup payload
controller
app
gn
labels
Jul 11, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
July 11, 2023 13:20
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
July 11, 2023 13:20
PR #27890: Size comparison from 3956092 to 1752cc1 Increases (7 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702l, cyw30739, efr32, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 11, 2023
cecille
approved these changes
Jul 11, 2023
woody-apple
approved these changes
Jul 11, 2023
yunhanw-google
approved these changes
Jul 11, 2023
This PR should wait for the #27881 to be attached and I think it will be the last one related to flake8. |
DamMicSzm
force-pushed
the
flake8-fix-other-python-files
branch
from
July 12, 2023 11:00
1752cc1
to
0fe3e9b
Compare
PR #27890: Size comparison from ab4509c to 0fe3e9b Increases (13 builds for bl602, bl702, bl702l, psoc6, qpg, telink)
Decreases (6 builds for bl602, efr32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
documentation
Improvements or additions to documentation
examples
gn
review - approved
setup payload
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a part of #25193 ( part fix python files in other python files )
Problem
Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.
Changes
Fix all python files in other python files where linter find problem. Adding python tests to check with flake8.
Testing
CI will test and maybe some another manual testing