-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestReliableMessageProtocol timing bug. #27817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could end up retransmitting a message due to losing the timeslice when we only meant to send it once. The fix is to make our stopping and starting of the reliable message manager timer in the test a lot less ad-hoc: we stop it whenever we block sending an ack (so that the other side will not retransmit), then restart it when we want to allow acks again (because at that point we want to make sure we retransmit things as needed). Fixes project-chip#27810
PR #27817: Size comparison from 27bb754 to 2b948fb Increases (11 builds for bl702l, cyw30739, esp32, k32w, psoc6, telink)
Decreases (6 builds for bl602, efr32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could end up retransmitting a message due to losing the timeslice when we only meant to send it once.
The fix is to make our stopping and starting of the reliable message manager timer in the test a lot less ad-hoc: we stop it whenever we block sending an ack (so that the other side will not retransmit), then restart it when we want to allow acks again (because at that point we want to make sure we retransmit things as needed).
Fixes #27810