Make MinMDNS only report commissiabe nodes for active browse. #27670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinMDNS had no way to differentiate what type of active commissionable browse operations existed so would report any commissioner or commissionable node the same to devices. This would make commissioner devices like chip-tool be able to detect themselves as 'commissionable' resulting in failed processing.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #27670: Size comparison from f7eff71 to 529f029 Increases (8 builds for bl602, bl702l, cc32xx, linux, mbed, nrfconnect)
Full report (14 builds for bl602, bl702, bl702l, cc32xx, linux, mbed, nrfconnect, qpg)
|
tcarmelveilleux
approved these changes
Jul 6, 2023
|
PR #27670: Size comparison from f7eff71 to a41102d Increases (33 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (9 builds for cyw30739, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #27670: Size comparison from 2f875c7 to d6fb6fc Increases (34 builds for bl602, bl702l, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (2 builds for bl702, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jul 7, 2023
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinMDNS had no way to differentiate what type of active commissionable browse operations existed so would report any commissioner or commissionable node the same to devices.
This would make commissioner devices like chip-tool be able to detect themselves as 'commissionable' resulting in failed processing.