-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow json tracing to go to files instead of just logs #27628
Merged
mergify
merged 12 commits into
project-chip:master
from
andy31415:make_json_tracing_generic
Jul 5, 2023
Merged
Allow json tracing to go to files instead of just logs #27628
mergify
merged 12 commits into
project-chip:master
from
andy31415:make_json_tracing_generic
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
July 5, 2023 13:47
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
July 5, 2023 13:47
PR #27628: Size comparison from dd09512 to 399d15a Decreases (4 builds for bl602, bl702, qpg)
Full report (12 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect, qpg)
|
PR #27628: Size comparison from dd09512 to 7b686f1 Increases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #27628: Size comparison from dd09512 to 371adb6 Increases (4 builds for bl702l, cc32xx, cyw30739, linux)
Decreases (8 builds for bl602, bl702, cyw30739, psoc6, qpg)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27628: Size comparison from dd09512 to 3c0c0f6 Increases above 0.2%:
Increases (14 builds for cc32xx, cyw30739, esp32, linux, telink)
Decreases (13 builds for bl602, bl702, bl702l, esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jul 5, 2023
arkq
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputting tracing data into logs is noisy. Generally one wants formatted data in dedicated files, so provide the option to write logs into files.
This changes a
--trace-to log
to be replaced with--trace-to json:log
however more generally we now support--trace-to json:$HOME/mylog.json
and which can be processed usingjq
or similar.Changes:
log_json
to justjson
in tracingTested: