-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASR] Delete duplicate implementations and docs #27625
Merged
andy31415
merged 2 commits into
project-chip:master
from
tx2rx:update_led_and_button_manager
Jul 6, 2023
Merged
[ASR] Delete duplicate implementations and docs #27625
andy31415
merged 2 commits into
project-chip:master
from
tx2rx:update_led_and_button_manager
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx2rx
force-pushed
the
update_led_and_button_manager
branch
from
July 5, 2023 09:09
60c0c21
to
0189309
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
July 5, 2023 09:09
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
July 5, 2023 09:09
tx2rx
force-pushed
the
update_led_and_button_manager
branch
from
July 5, 2023 09:15
0189309
to
0ce834e
Compare
PR #27625: Size comparison from fa07cc9 to 0ce834e Increases (11 builds for bl702, bl702l, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, cyw30739, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tx2rx
changed the title
[ASR] Delete duplicate led and button implementations, all move to platform…
[ASR] Delete duplicate implementations and docs
Jul 6, 2023
tx2rx
force-pushed
the
update_led_and_button_manager
branch
from
July 6, 2023 06:14
0ce834e
to
5f6cd6d
Compare
PR #27625: Size comparison from d55f685 to 5f6cd6d Increases (9 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for cc32xx, esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Delete duplicate implementations for all asr examples
Because this is all platform-specific code , move LEDWidget and ButtonHandler to examples/platform/asr
2, Delete "support chips" in asr examples doc , that's already described in asr guide