-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concentration Measurement Editorial Update for Enum Names and Time Window Constraints #27576
Merged
mergify
merged 2 commits into
project-chip:master
from
dysonltd:conc-meas-editorial-update
Jul 3, 2023
Merged
Concentration Measurement Editorial Update for Enum Names and Time Window Constraints #27576
mergify
merged 2 commits into
project-chip:master
from
dysonltd:conc-meas-editorial-update
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges and making changes to the time windows in line with spec changes
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248 and
jelderton
June 30, 2023 14:57
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 30, 2023 14:57
p0fi
approved these changes
Jun 30, 2023
PR #27576: Size comparison from 5c7d81d to a4183cc Increases (9 builds for esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mhazley
changed the title
Conc meas editorial update
Concentration Measurement Editorial Update for Enum Names and Time Window Constraints
Jun 30, 2023
woody-apple
approved these changes
Jun 30, 2023
tcarmelveilleux
approved these changes
Jul 3, 2023
jmeg-sfy
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following two spec changes:
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7176
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7117
Need to make some changes to Concentration XML's and supporting files.
Links
Fixes #27289