-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manual code processing in Python matter_testing_support #27558
Merged
mergify
merged 1 commit into
project-chip:master
from
tcarmelveilleux:fix-leading-zeroes
Jun 29, 2023
Merged
Fix manual code processing in Python matter_testing_support #27558
mergify
merged 1 commit into
project-chip:master
from
tcarmelveilleux:fix-leading-zeroes
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Leading zeroes in manual pairing code were lost due to a conversion bug, which prevented proper usage - Found during plugfest This PR: - Avoids a round trip that removed leading zeroes and fixes the conversion to be lossless while retaining structural validation. - Allows spaces in passcode. Testing done: - Executed TC_DeviceBasicComposition with a --manual-code having leading zeroes, against chip-lighting-app. - Regression tests of TC_*.py
tcarmelveilleux
changed the title
Fix manual code processing in python_testing_support
Fix manual code processing in Python matter_testing_support
Jun 29, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
June 29, 2023 19:27
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 29, 2023 19:27
PR #27558: Size comparison from a39e88a to 1899406 Increases (13 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Decreases (11 builds for esp32, k32w, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 29, 2023
LGTM |
andy31415
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR changes
Testing done