-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ameba] ota fix blocking erase flash and cleanup #27513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankore
commented
Jun 28, 2023
- Fix [BUG] [OTA] event not reported in time #27379
- Flash erase will be handled by lower layer and will not block for 20s
- Cleanup code
PR #27513: Size comparison from 23a0064 to bc50699 Increases (4 builds for cc32xx, telink)
Decreases (10 builds for bl702, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27513: Size comparison from 23a0064 to 71e79b3 Increases (6 builds for psoc6, telink)
Decreases (9 builds for bl602, cc32xx, esp32, k32w, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27513: Size comparison from def0efa to 46465c7 Increases (8 builds for bl702, bl702l, psoc6, qpg, telink)
Decreases (9 builds for cc32xx, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27513: Size comparison from 7ae5919 to 2c3bbad Increases (8 builds for bl702, bl702l, esp32, qpg, telink)
Decreases (13 builds for bl602, cc32xx, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27513: Size comparison from 79cebcf to c046c99 Increases (9 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, esp32, k32w, nrfconnect, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- erase flash will not block for 20seconds
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex and
harsha-rajendran
July 17, 2023 01:54
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mlepage-google,
msandstedt,
nivi-apple,
p0fi,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
July 17, 2023 01:54
woody-apple
approved these changes
Jul 18, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
- erase flash will not block for 20seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.