-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Removal of Optional for AttributeId #27509
Merged
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/attribute_value_pair_optional
Jun 28, 2023
Merged
[Scenes] Removal of Optional for AttributeId #27509
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/attribute_value_pair_optional
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactored tests and clusters to work with the changes
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
June 27, 2023 17:47
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 27, 2023 17:47
pullapprove
bot
added
review - pending
examples
darwin
controller
app
tests
and removed
examples
darwin
controller
app
tests
labels
Jun 27, 2023
woody-apple
approved these changes
Jun 27, 2023
Tagging @bzbarsky-apple here, this will result in incompatible Darwin API, but maybe not a big deal... considering nobody would have adopted them yet. |
PR #27509: Size comparison from 1c694cf to 42df331 Increases (19 builds for bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (33 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 28, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
approved these changes
Jun 28, 2023
PR #27509: Size comparison from 1c694cf to d8ef748 Increases (21 builds for bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (34 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data model previously had AttributeId (from AttributePair, from ExtensionFieldSets, from Scenes) as optional, which isn't spec compliant (see issue ).
The PR changes that and refactors the EFS code to handle the change.