-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Add Descriptor cluster for Secondary Network Commissoning Endpoint #27493
Merged
mergify
merged 1 commit into
project-chip:master
from
wqx6:secondary_network_commissioning/add_descriptor
Jul 3, 2023
Merged
examples: Add Descriptor cluster for Secondary Network Commissoning Endpoint #27493
mergify
merged 1 commit into
project-chip:master
from
wqx6:secondary_network_commissioning/add_descriptor
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
June 27, 2023 03:25
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 27, 2023 03:26
PR #27493: Size comparison from a60604b to 2c1ed86 Increases (20 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 27, 2023
wqx6
force-pushed
the
secondary_network_commissioning/add_descriptor
branch
from
June 28, 2023 03:16
2c1ed86
to
d1dbff0
Compare
PR #27493: Size comparison from 23a0064 to d1dbff0 Increases (21 builds for bl702, bl702l, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for esp32, k32w, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chshu
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each device type definition SHALL include Descriptor cluster, but now the Secondary Network Commissoning endpoints in all-clusters-app and all-cluster-minimal-app don't include Descriptor cluster. We should add the cluster for these endpoints.