[Examples] Create common tv-app sources #27408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATmobica
force-pushed
the
upstream/tv-app-common-source
branch
2 times, most recently
from
2fab1b1 to
2e00584
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #27408: Size comparison from a816538 to 2e00584 Increases (1 build for cc32xx)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
ATmobica
force-pushed
the
upstream/tv-app-common-source
branch
from
2e00584 to
5619488
Compare
|
PR #27408: Size comparison from 71d7a95 to 5619488 Increases (16 builds for bl702, esp32, k32w, linux, psoc6, telink)
Decreases (8 builds for bl602, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 22, 2023
ATmobica
force-pushed
the
upstream/tv-app-common-source
branch
from
5619488 to
b6670c0
Compare
Move cluster handlers, app platform and shell command implementations, ZCL callbacks from Linux to tv-common directory. Create source set with tv-app source files. Create cmake macro to add common tv-app sources to the specific target. Use common tv-app sources in Linux tv-app example. Sources can now be easily shared across platform implementations. Signed-off-by: ATmobica <[email protected]>
|
PR #27408: Size comparison from c8b49b9 to b6670c0 Increases (11 builds for bl702, cc32xx, esp32, linux, psoc6, qpg, telink)
Decreases (7 builds for bl702, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move cluster handlers, app platform and shell command implementations, ZCL callbacks from Linux to tv-common directory.
Create source set with tv-app source files.
Create cmake macro to add common tv-app sources to the specific target.
Use common tv-app sources in Linux tv-app example.
Sources can now be easily shared across platform implementations.