Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the comma split work in zsh #27347

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Make the comma split work in zsh #27347

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed7614a
Make the comma split work in zsh
andreilitvin Jun 20, 2023
7ed00c8
Update string substitution a bit
andreilitvin Jun 20, 2023
4fcfa39
Remove extra conditional
andreilitvin Jun 20, 2023
98ef8be
Use zsh_version to determine how to read
andreilitvin Jun 20, 2023
6ea547e
Slight simplification
andreilitvin Jun 20, 2023
515c1c1
Cleanup variables as well
andreilitvin Jun 20, 2023
190d60d
Restyled by shfmt
restyled-commits Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/setup/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ _install_additional_pip_requirements() {
done

if ! [ -z "$_SETUP_PLATFORM" ]; then
IFS="," read -r -a _PLATFORMS <<<"$_SETUP_PLATFORM"
if [ -n "$ZSH_VERSION" ]; then
IFS="," read -r -A _PLATFORMS <<<"$_SETUP_PLATFORM"
else
IFS="," read -r -a _PLATFORMS <<<"$_SETUP_PLATFORM"
fi
for platform in "${_PLATFORMS[@]}"; do
# Allow none as an alias of nothing extra installed (like -p none)
if [ "$platform" != "none" ]; then
Expand All @@ -43,7 +47,10 @@ _install_additional_pip_requirements() {
-c "$_CHIP_ROOT/scripts/setup/constraints.txt"
fi
done
unset _PLATFORMS
fi

unset _SETUP_PLATFORM
}

_bootstrap_or_activate() {
Expand Down