-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Update minLength/maxLength constraints to allow nu… #27312
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_MinMaxLengthAllowNull
Jun 20, 2023
Merged
[matter_yamltests] Update minLength/maxLength constraints to allow nu… #27312
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_MinMaxLengthAllowNull
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
June 19, 2023 09:05
pullapprove
bot
requested review from
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 19, 2023 09:05
pullapprove
bot
requested review from
LuDuda,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 19, 2023 09:05
PR #27312: Size comparison from f5c4621 to 32de269 Increases (14 builds for bl702, cyw30739, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 19, 2023
woody-apple
approved these changes
Jun 20, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 20, 2023
This is the darwin-framework-tool equivalent of project-chip#27312
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 20, 2023
This is the darwin-framework-tool equivalent of project-chip#27312 Also fixes a similar issue for minValue/maxValue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll values
Problem
This PR allows
null
value for a nullable string to successfully pass aminLength
/maxLength
constraint. This is similar tominValue
/maxValue
for numbers.