Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that auto commissioner gets the attribute values it expects. #27301

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Ensure that auto commissioner gets the attribute values it expects. #27301

merged 2 commits into from
Jun 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

If a device failed to, for example, send us an actual value for the VendorID attribute, we would silently end up using some random value for it during commissioning, probably right up until device attestation failed.

Instead of relying on that, we should just explicitly error out if the attributes that must be present (VendorID, ProductID, BasicCommissioningInfo, etc) don't exist.

@bzbarsky-apple bzbarsky-apple force-pushed the auto-commissioner-ensure-data branch from 98b4688 to 44df906 Compare June 16, 2023 21:19
@github-actions
Copy link

github-actions bot commented Jun 16, 2023 •
edited
Loading

PR #27301: Size comparison from aa13fa3 to 44df906

Increases (8 builds for efr32, esp32, psoc6, telink)
platform target config section aa13fa3 44df906 change % change
efr32 lighting-app BRD4187C (read/write) 1027088 1027096 8 0.0
.text 862708 862716 8 0.0
esp32 all-clusters-app c3devkit (read only) 1075248 1075250 2 0.0
.flash.text 1075248 1075250 2 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 28271856 28271857 1 0.0
light cy8ckit_062s2_43012 .debug_info 23071708 23071710 2 0.0
telink bridge-app tlsr9518adk80d (read/write) 929400 929408 8 0.0
text 642504 642506 2 0.0
lighting-app-rpc tlsr9518adk80d text 724218 724222 4 0.0
thermostat tlsr9518adk80d text 616690 616692 2 0.0
window-covering tlsr9518adk80d (read/write) 891032 891040 8 0.0
text 611610 611614 4 0.0
Decreases (17 builds for bl602, bl702, cc32xx, linux, psoc6, telink)
platform target config section aa13fa3 44df906 change % change
bl602 lighting-app bl602 (read/write) 1368690 1368682 -8 -0.0
.text 1049084 1049080 -4 -0.0
bl602+rpc .text 1081224 1081222 -2 -0.0
bl702 lighting-app bl702 .debug_info 41575607 41575606 -1 -0.0
.text 945036 945034 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19902544 19902543 -1 -0.0
linux chip-tool debug (read only) 16297521 16296913 -608 -0.0
.text 13815668 13815060 -608 -0.0
chip-tool-ipv6only arm64 (read only) 15633416 15632936 -480 -0.0
.rodata 665792 665776 -16 -0.0
.text 13057140 13056676 -464 -0.0
tv-app debug (read only) 3319865 3319273 -592 -0.0
.text 2901314 2900722 -592 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28810970 28810969 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22782795 22782794 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1034864 1034856 -8 -0.0
text 708064 708060 -4 -0.0
light-switch-app tlsr9518adk80d (read/write) 877464 877456 -8 -0.0
text 600334 600332 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 977028 977020 -8 -0.0
text 686846 686844 -2 -0.0
lighting-app-shell tlsr9518adk80d text 744364 744362 -2 -0.0
lock-app tlsr9518adk80d text 614338 614334 -4 -0.0
ota-requestor-app tlsr9518adk80d text 607484 607480 -4 -0.0
pump-app tlsr9518adk80d text 591430 591428 -2 -0.0
temperature-measurement-app tlsr9518adk80d text 577444 577442 -2 -0.0
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section aa13fa3 44df906 change % change
bl602 lighting-app bl602 (read/write) 1368690 1368682 -8 -0.0
.bss 88182 88182 0 0.0
.data 9584 9584 0 0.0
.text 1049084 1049080 -4 -0.0
bl602+rpc (read/write) 1416358 1416358 0 0.0
.bss 96230 96230 0 0.0
.data 9976 9976 0 0.0
.text 1081224 1081222 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1173707 1173707 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77773 77773 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3576 3576 0 0.0
.debug_abbrev 1545541 1545541 0 0.0
.debug_aranges 149824 149824 0 0.0
.debug_frame 551456 551456 0 0.0
.debug_info 41575607 41575606 -1 -0.0
.debug_line 5578046 5578046 0 0.0
.debug_loc 3797431 3797431 0 0.0
.debug_ranges 394824 394824 0 0.0
.debug_str 4346521 4346521 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 104972 104972 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 581710 581710 0 0.0
.symtab 173904 173904 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
945036 945034 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1271651 1271651 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85821 85821 0 0.0
.bss_psram 25072 25072 0 0.0
.comment 48 48 0 0.0
.data 4136 4136 0 0.0
.debug_abbrev 1710730 1710730 0 0.0
.debug_aranges 158304 158304 0 0.0
.debug_frame 580088 580088 0 0.0
.debug_info 46756794 46756794 0 0.0
.debug_line 6003795 6003795 0 0.0
.debug_loc 4002706 4002706 0 0.0
.debug_ranges 420504 420504 0 0.0
.debug_str 4775195 4775195 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119568 119568 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 644310 644310 0 0.0
.symtab 192704 192704 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1018784 1018784 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606626 606626 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 948102 948102 0 0.0
.debug_aranges 118992 118992 0 0.0
.debug_frame 406416 406416 0 0.0
.debug_info 19902544 19902543 -1 -0.0
.debug_line 2872064 2872064 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1727366 1727366 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107553 107553 0 0.0
.debug_str 3787494 3787494 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104450 104450 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484353 484353 0 0.0
.symtab 287776 287776 0 0.0
.text 500052 500052 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 543127 543127 0 0.0
.app_xip_area 435745 435745 0 0.0
.bss 62360 62360 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 530135 530135 0 0.0
.app_xip_area 417625 417625 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 567551 567551 0 0.0
.app_xip_area 461105 461105 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531975 531975 0 0.0
.app_xip_area 422961 422961 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 994596 994596 0 0.0
.bss 181848 181848 0 0.0
.data 2144 2144 0 0.0
.text 810584 810584 0 0.0
BRD4187C (read/write) 1027088 1027096 8 0.0
.bss 161572 161572 0 0.0
.data 2788 2788 0 0.0
.text 862708 862716 8 0.0
lock-app BRD4161A+wf200 (read/write) 1075752 1075752 0 0.0
.bss 176136 176136 0 0.0
.data 2152 2152 0 0.0
.text 897444 897444 0 0.0
window-app BRD4187C (read/write) 1097152 1097152 0 0.0
.bss 144548 144548 0 0.0
.data 2680 2680 0 0.0
.text 949904 949904 0 0.0
esp32 all-clusters-app c3devkit (read only) 1075248 1075250 2 0.0
(read/write) 1584280 1584280 0 0.0
.dram0.bss 75392 75392 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 215808 215808 0 0.0
.flash.text 1075248 1075250 2 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1123231 1123231 0 0.0
(read/write) 494734 494734 0 0.0
.dram0.bss 80888 80888 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244392 244392 0 0.0
.flash.text 1117847 1117847 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 585732 585732 0 0.0
(read/write) 90096 90096 0 0.0
.bss 66100 66100 0 0.0
.data 2168 2168 0 0.0
.text 585196 585196 0 0.0
light k32w0+release (read only) 584356 584356 0 0.0
(read/write) 89744 89744 0 0.0
.bss 65764 65764 0 0.0
.data 2156 2156 0 0.0
.text 583820 583820 0 0.0
lock k32w0+release (read only) 557012 557012 0 0.0
(read/write) 87568 87568 0 0.0
.bss 63636 63636 0 0.0
.data 2100 2100 0 0.0
.text 556476 556476 0 0.0
linux all-clusters-app debug (read only) 3266829 3266829 0 0.0
(read/write) 158784 158784 0 0.0
.bss 59520 59520 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90584 90584 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 231336 231336 0 0.0
.text 2844549 2844549 0 0.0
all-clusters-minimal-app debug (read only) 3044621 3044621 0 0.0
(read/write) 145840 145840 0 0.0
.bss 57920 57920 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1096 1096 0 0.0
.rodata 223848 223848 0 0.0
.text 2634853 2634853 0 0.0
bridge-app debug (read only) 2524373 2524373 0 0.0
(read/write) 129808 129808 0 0.0
.bss 50264 50264 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 172456 172456 0 0.0
.text 2179141 2179141 0 0.0
chip-tool debug (read only) 16297521 16296913 -608 -0.0
(read/write) 754184 754184 0 0.0
.bss 26392 26392 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 717928 717928 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 729901 729901 0 0.0
.text 13815668 13815060 -608 -0.0
chip-tool-ipv6only arm64 (read only) 15633416 15632936 -480 -0.0
(read/write) 807624 807624 0 0.0
.bss 34376 34376 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 747808 747808 0 0.0
.dynamic 560 560 0 0.0
.got 17160 17160 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 665792 665776 -16 -0.0
.text 13057140 13056676 -464 -0.0
lighting-app debug+rpc+ui (read only) 3389737 3389737 0 0.0
(read/write) 136312 136312 0 0.0
.bss 49760 49760 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 286164 286164 0 0.0
.text 2906162 2906162 0 0.0
lock-app debug (read only) 2617069 2617069 0 0.0
(read/write) 117208 117208 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 199944 199944 0 0.0
.text 2252517 2252517 0 0.0
ota-provider-app debug (read only) 2213845 2213845 0 0.0
(read/write) 103816 103816 0 0.0
.bss 44544 44544 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 153672 153672 0 0.0
.text 1918197 1918197 0 0.0
ota-requestor-app debug (read only) 2382701 2382701 0 0.0
(read/write) 111576 111576 0 0.0
.bss 46976 46976 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 157736 157736 0 0.0
.text 2074117 2074117 0 0.0
shell debug (read only) 2802265 2802265 0 0.0
(read/write) 147168 147168 0 0.0
.bss 58440 58440 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81640 81640 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 199538 199538 0 0.0
.text 2435810 2435810 0 0.0
thermostat-no-ble arm64 (read only) 2610316 2610316 0 0.0
(read/write) 143000 143000 0 0.0
.bss 52360 52360 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79264 79264 0 0.0
.dynamic 560 560 0 0.0
.got 5520 5520 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 129520 129520 0 0.0
.text 2215316 2215316 0 0.0
tv-app debug (read only) 3319865 3319273 -592 -0.0
(read/write) 261672 261672 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79616 79616 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 221912 221912 0 0.0
.text 2901314 2900722 -592 -0.0
tv-casting-app debug (read only) 9240529 9240529 0 0.0
(read/write) 220056 220056 0 0.0
.bss 52128 52128 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159616 159616 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 333412 333412 0 0.0
.text 8476978 8476978 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2498304 2498304 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460988 1460988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1210932 1210932 0 0.0
bss 154803 154803 0 0.0
rodata 137800 137800 0 0.0
text 839208 839208 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1313636 1313636 0 0.0
bss 138133 138133 0 0.0
rodata 133224 133224 0 0.0
text 751572 751572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148640 1148640 0 0.0
bss 153317 153317 0 0.0
rodata 111108 111108 0 0.0
text 805204 805204 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841944 841944 0 0.0
(read/write) 1728932 1728932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188836 188836 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1293774 1293774 0 0.0
.debug_aranges 148776 148776 0 0.0
.debug_frame 498236 498236 0 0.0
.debug_info 28810970 28810969 -1 -0.0
.debug_line 4025309 4025309 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2303799 2303799 0 0.0
.debug_rnglists 144237 144237 0 0.0
.debug_str 4354927 4354927 0 0.0
.heap 841944 841944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750780 750780 0 0.0
.symtab 478672 478672 0 0.0
.text 1529148 1529148 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843384 843384 0 0.0
(read/write) 1660860 1660860 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187396 187396 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1281482 1281482 0 0.0
.debug_aranges 147528 147528 0 0.0
.debug_frame 499180 499180 0 0.0
.debug_info 28271856 28271857 1 0.0
.debug_line 4030279 4030279 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2288630 2288630 0 0.0
.debug_rnglists 142683 142683 0 0.0
.debug_str 4337857 4337857 0 0.0
.heap 843384 843384 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699661 699661 0 0.0
.symtab 459792 459792 0 0.0
.text 1462516 1462516 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849568 849568 0 0.0
(read/write) 1593724 1593724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181380 181380 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1118316 1118316 0 0.0
.debug_aranges 137888 137888 0 0.0
.debug_frame 463144 463144 0 0.0
.debug_info 23071708 23071710 2 0.0
.debug_line 3602425 3602425 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2129834 2129834 0 0.0
.debug_rnglists 132693 132693 0 0.0
.debug_str 4151876 4151876 0 0.0
.heap 849568 849568 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623284 623284 0 0.0
.symtab 425392 425392 0 0.0
.text 1401564 1401564 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821968 821968 0 0.0
(read/write) 1626764 1626764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208980 208980 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1100903 1100903 0 0.0
.debug_aranges 136184 136184 0 0.0
.debug_frame 457112 457112 0 0.0
.debug_info 22782795 22782794 -1 -0.0
.debug_line 3540270 3540270 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2101057 2101057 0 0.0
.debug_rnglists 130404 130404 0 0.0
.debug_str 4108528 4108528 0 0.0
.heap 821968 821968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596254 596254 0 0.0
.symtab 416992 416992 0 0.0
.text 1407004 1407004 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1171808 1171808 0 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 618648 618648 0 0.0
lock-app qpg6105+debug (read/write) 1129512 1129512 0 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 576356 576356 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034864 1034856 -8 -0.0
bss 97716 97716 0 0.0
text 708064 708060 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961488 961488 0 0.0
bss 96116 96116 0 0.0
text 665322 665322 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929400 929408 8 0.0
bss 100308 100308 0 0.0
text 642504 642506 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861140 861140 0 0.0
bss 89968 89968 0 0.0
text 585708 585708 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877464 877456 -8 -0.0
bss 90136 90136 0 0.0
text 600334 600332 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965648 965648 0 0.0
bss 98500 98500 0 0.0
text 679326 679326 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 977028 977020 -8 -0.0
bss 102748 102748 0 0.0
text 686846 686844 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1035148 1035148 0 0.0
bss 100064 100064 0 0.0
text 724218 724222 4 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1066496 1066496 0 0.0
bss 111140 111140 0 0.0
text 744364 744362 -2 -0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916212 916212 0 0.0
bss 90632 90632 0 0.0
text 614338 614334 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883668 883668 0 0.0
bss 91244 91244 0 0.0
text 607484 607480 -4 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866700 866700 0 0.0
bss 90100 90100 0 0.0
text 591430 591428 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853760 853760 0 0.0
bss 89900 89900 0 0.0
text 581812 581812 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849916 849916 0 0.0
bss 89808 89808 0 0.0
text 577444 577442 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 895660 895660 0 0.0
bss 90344 90344 0 0.0
text 616690 616692 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 891032 891040 8 0.0
bss 90636 90636 0 0.0
text 611610 611614 4 0.0

@bzbarsky-apple
Ensure that auto commissioner gets the attribute values it expects.
75e63ab 
If a device failed to, for example, send us an actual value for the VendorID
attribute, we would silently end up using some random value for it during
commissioning, probably right up until device attestation failed.

Instead of relying on that, we should just explicitly error out if the
attributes that must be present (VendorID, ProductID, BasicCommissioningInfo,
etc) don't exist.
@bzbarsky-apple
Address review comments.
f885839
@bzbarsky-apple bzbarsky-apple force-pushed the auto-commissioner-ensure-data branch from 360a44b to f885839 Compare June 23, 2023 06:34
@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

PR #27301: Size comparison from 875c577 to f885839

Increases (11 builds for cc32xx, esp32, linux, psoc6, telink)
platform target config section 875c577 f885839 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19923170 19923171 1 0.0
esp32 all-clusters-app c3devkit (read/write) 1585008 1585016 8 0.0
.flash.rodata 216312 216320 8 0.0
linux chip-tool debug .rodata 736765 736925 160 0.0
chip-tool-ipv6only arm64 .rodata 672552 672680 128 0.0
tv-app debug .rodata 223832 223992 160 0.1
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 29007672 29007673 1 0.0
light cy8ckit_062s2_43012 .debug_info 23108118 23108119 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 877956 877964 8 0.0
text 600628 600630 2 0.0
lighting-app-shell tlsr9518adk80d (read/write) 1069372 1069380 8 0.0
text 746760 746762 2 0.0
pump-controller-app tlsr9518adk80d text 582108 582110 2 0.0
temperature-measurement-app tlsr9518adk80d text 577738 577740 2 0.0
Decreases (13 builds for bl602, bl702, esp32, linux, nrfconnect, psoc6, telink)
platform target config section 875c577 f885839 change % change
bl602 lighting-app bl602 .text 1050918 1050916 -2 -0.0
bl702 lighting-app bl702 (read/write) 1175211 1175207 -4 -0.0
.debug_info 41613026 41613025 -1 -0.0
.text 946054 946052 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1078004 1078002 -2 -0.0
.flash.text 1078004 1078002 -2 -0.0
linux chip-tool debug (read only) 16412497 16412273 -224 -0.0
.text 13902180 13901796 -384 -0.0
chip-tool-ipv6only arm64 (read only) 15740096 15739936 -160 -0.0
.text 13135300 13135012 -288 -0.0
tv-app debug (read only) 3327225 3327001 -224 -0.0
.text 2906370 2905986 -384 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 753748 753744 -4 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22804086 22804085 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 710456 710454 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 667738 667736 -2 -0.0
bridge-app tlsr9518adk80d (read/write) 929940 929932 -8 -0.0
text 642834 642832 -2 -0.0
contact-sensor-app tlsr9518adk80d text 586006 586002 -4 -0.0
thermostat tlsr9518adk80d text 617158 617156 -2 -0.0
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 875c577 f885839 change % change
bl602 lighting-app bl602 (read/write) 1366494 1366494 0 0.0
.bss 83942 83942 0 0.0
.data 9608 9608 0 0.0
.text 1050918 1050916 -2 -0.0
bl602+rpc (read/write) 1414178 1414178 0 0.0
.bss 91990 91990 0 0.0
.data 10008 10008 0 0.0
.text 1083056 1083056 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1175211 1175207 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77781 77781 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3592 3592 0 0.0
.debug_abbrev 1545845 1545845 0 0.0
.debug_aranges 149976 149976 0 0.0
.debug_frame 552036 552036 0 0.0
.debug_info 41613026 41613025 -1 -0.0
.debug_line 5583553 5583553 0 0.0
.debug_loc 3800882 3800882 0 0.0
.debug_ranges 395256 395256 0 0.0
.debug_str 4350605 4350605 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105408 105408 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582415 582415 0 0.0
.symtab 174192 174192 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
946054 946052 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273323 1273323 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85829 85829 0 0.0
.bss_psram 25072 25072 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1711094 1711094 0 0.0
.debug_aranges 158448 158448 0 0.0
.debug_frame 580668 580668 0 0.0
.debug_info 46797389 46797389 0 0.0
.debug_line 6009861 6009861 0 0.0
.debug_loc 4006153 4006153 0 0.0
.debug_ranges 420928 420928 0 0.0
.debug_str 4779233 4779233 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120048 120048 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 644984 644984 0 0.0
.symtab 192992 192992 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1019934 1019934 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 607482 607482 0 0.0
(read/write) 204172 204172 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197584 197584 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 948407 948407 0 0.0
.debug_aranges 119128 119128 0 0.0
.debug_frame 406836 406836 0 0.0
.debug_info 19923170 19923171 1 0.0
.debug_line 2873951 2873951 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1729074 1729074 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107669 107669 0 0.0
.debug_str 3792182 3792182 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104650 104650 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484980 484980 0 0.0
.symtab 288160 288160 0 0.0
.text 500712 500712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 545239 545239 0 0.0
.app_xip_area 437649 437649 0 0.0
.bss 62568 62568 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 530287 530287 0 0.0
.app_xip_area 417777 417777 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 567983 567983 0 0.0
.app_xip_area 461537 461537 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 532087 532087 0 0.0
.app_xip_area 423073 423073 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 997752 997752 0 0.0
.bss 182064 182064 0 0.0
.data 2148 2148 0 0.0
.text 813516 813516 0 0.0
BRD4187C (read/write) 1029436 1029436 0 0.0
.bss 161788 161788 0 0.0
.data 2792 2792 0 0.0
.text 864836 864836 0 0.0
lock-app BRD4161A+wf200 (read/write) 1075920 1075920 0 0.0
.bss 176120 176120 0 0.0
.data 2152 2152 0 0.0
.text 897628 897628 0 0.0
window-app BRD4187C (read/write) 1097332 1097332 0 0.0
.bss 144740 144740 0 0.0
.data 2688 2688 0 0.0
.text 949884 949884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1078004 1078002 -2 -0.0
(read/write) 1585008 1585016 8 0.0
.dram0.bss 75616 75616 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 216312 216320 8 0.0
.flash.text 1078004 1078002 -2 -0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1125707 1125707 0 0.0
(read/write) 495454 495454 0 0.0
.dram0.bss 81088 81088 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244912 244912 0 0.0
.flash.text 1120323 1120323 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 586132 586132 0 0.0
(read/write) 90104 90104 0 0.0
.bss 66108 66108 0 0.0
.data 2168 2168 0 0.0
.text 585596 585596 0 0.0
light k32w0+release (read only) 584820 584820 0 0.0
(read/write) 89752 89752 0 0.0
.bss 65772 65772 0 0.0
.data 2156 2156 0 0.0
.text 584284 584284 0 0.0
lock k32w0+release (read only) 557404 557404 0 0.0
(read/write) 87560 87560 0 0.0
.bss 63636 63636 0 0.0
.data 2100 2100 0 0.0
.text 556868 556868 0 0.0
linux all-clusters-app debug (read only) 3284037 3284037 0 0.0
(read/write) 159656 159656 0 0.0
.bss 59872 59872 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 91112 91112 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 232616 232616 0 0.0
.text 2859445 2859445 0 0.0
all-clusters-minimal-app debug (read only) 3061741 3061741 0 0.0
(read/write) 146608 146608 0 0.0
.bss 58272 58272 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79800 79800 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1096 1096 0 0.0
.rodata 225096 225096 0 0.0
.text 2649765 2649765 0 0.0
bridge-app debug (read only) 2530725 2530725 0 0.0
(read/write) 129968 129968 0 0.0
.bss 50296 50296 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 173608 173608 0 0.0
.text 2183957 2183957 0 0.0
chip-tool debug (read only) 16412497 16412273 -224 -0.0
(read/write) 763272 763272 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 726984 726984 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 736765 736925 160 0.0
.text 13902180 13901796 -384 -0.0
chip-tool-ipv6only arm64 (read only) 15740096 15739936 -160 -0.0
(read/write) 816760 816760 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 756864 756864 0 0.0
.dynamic 560 560 0 0.0
.got 17232 17232 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 672552 672680 128 0.0
.text 13135300 13135012 -288 -0.0
lighting-app debug+rpc+ui (read only) 3406745 3406745 0 0.0
(read/write) 137080 137080 0 0.0
.bss 50144 50144 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 77344 77344 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 287444 287444 0 0.0
.text 2920930 2920930 0 0.0
lock-app debug (read only) 2623421 2623421 0 0.0
(read/write) 117368 117368 0 0.0
.bss 45376 45376 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 64024 64024 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201096 201096 0 0.0
.text 2257333 2257333 0 0.0
ota-provider-app debug (read only) 2219477 2219477 0 0.0
(read/write) 103976 103976 0 0.0
.bss 44576 44576 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52184 52184 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 154696 154696 0 0.0
.text 1922421 1922421 0 0.0
ota-requestor-app debug (read only) 2388909 2388909 0 0.0
(read/write) 111736 111736 0 0.0
.bss 47008 47008 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 57040 57040 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 158824 158824 0 0.0
.text 2078853 2078853 0 0.0
shell debug (read only) 2819249 2819249 0 0.0
(read/write) 148072 148072 0 0.0
.bss 58824 58824 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 200658 200658 0 0.0
.text 2450642 2450642 0 0.0
thermostat-no-ble arm64 (read only) 2615868 2615868 0 0.0
(read/write) 143128 143128 0 0.0
.bss 52360 52360 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 560 560 0 0.0
.got 5520 5520 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 130496 130496 0 0.0
.text 2219508 2219508 0 0.0
tv-app debug (read only) 3327225 3327001 -224 -0.0
(read/write) 261832 261832 0 0.0
.bss 171264 171264 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79744 79744 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 223832 223992 160 0.1
.text 2906370 2905986 -384 -0.0
tv-casting-app debug (read only) 9241625 9241625 0 0.0
(read/write) 220216 220216 0 0.0
.bss 52160 52160 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159744 159744 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 331132 331132 0 0.0
.text 8479922 8479922 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2499088 2499088 0 0.0
.bss 216312 216312 0 0.0
.data 5144 5144 0 0.0
.text 1461772 1461772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1213484 1213484 0 0.0
bss 155045 155045 0 0.0
rodata 138144 138144 0 0.0
text 841152 841152 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1316260 1316260 0 0.0
bss 138371 138371 0 0.0
rodata 133432 133432 0 0.0
text 753748 753744 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1151148 1151148 0 0.0
bss 153541 153541 0 0.0
rodata 111408 111408 0 0.0
text 807160 807160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841680 841680 0 0.0
(read/write) 1732324 1732324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189092 189092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2568 2568 0 0.0
.debug_abbrev 1299084 1299084 0 0.0
.debug_aranges 149272 149272 0 0.0
.debug_frame 499812 499812 0 0.0
.debug_info 29007672 29007673 1 0.0
.debug_line 4040096 4040096 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2310480 2310480 0 0.0
.debug_rnglists 144642 144642 0 0.0
.debug_str 4364006 4364006 0 0.0
.heap 841680 841680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 754286 754286 0 0.0
.symtab 480528 480528 0 0.0
.text 1532276 1532276 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843160 843160 0 0.0
(read/write) 1664172 1664172 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187620 187620 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1282129 1282129 0 0.0
.debug_aranges 147888 147888 0 0.0
.debug_frame 500364 500364 0 0.0
.debug_info 28310408 28310408 0 0.0
.debug_line 4035661 4035661 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2293770 2293770 0 0.0
.debug_rnglists 142990 142990 0 0.0
.debug_str 4344279 4344279 0 0.0
.heap 843160 843160 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 703099 703099 0 0.0
.symtab 461632 461632 0 0.0
.text 1465604 1465604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849352 849352 0 0.0
(read/write) 1596980 1596980 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181596 181596 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1118963 1118963 0 0.0
.debug_aranges 138248 138248 0 0.0
.debug_frame 464328 464328 0 0.0
.debug_info 23108118 23108119 1 0.0
.debug_line 3607705 3607705 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2134979 2134979 0 0.0
.debug_rnglists 133012 133012 0 0.0
.debug_str 4158298 4158298 0 0.0
.heap 849352 849352 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 626743 626743 0 0.0
.symtab 427200 427200 0 0.0
.text 1404604 1404604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1627700 1627700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1101242 1101242 0 0.0
.debug_aranges 136320 136320 0 0.0
.debug_frame 457532 457532 0 0.0
.debug_info 22804086 22804085 -1 -0.0
.debug_line 3542157 3542157 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2102867 2102867 0 0.0
.debug_rnglists 130506 130506 0 0.0
.debug_str 4113211 4113211 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596881 596881 0 0.0
.symtab 417408 417408 0 0.0
.text 1407932 1407932 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1172376 1172376 0 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 619216 619216 0 0.0
lock-app qpg6105+debug (read/write) 1129992 1129992 0 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 576836 576836 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1037852 1037852 0 0.0
bss 97960 97960 0 0.0
text 710456 710454 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964436 964436 0 0.0
bss 96340 96340 0 0.0
text 667738 667736 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929940 929932 -8 -0.0
bss 100312 100312 0 0.0
text 642834 642832 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861640 861640 0 0.0
bss 89972 89972 0 0.0
text 586006 586002 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877956 877964 8 0.0
bss 90140 90140 0 0.0
text 600628 600630 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 968524 968524 0 0.0
bss 98712 98712 0 0.0
text 681724 681724 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 979904 979904 0 0.0
bss 102960 102960 0 0.0
text 689244 689244 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1038016 1038016 0 0.0
bss 100268 100268 0 0.0
text 726614 726614 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1069372 1069380 8 0.0
bss 111352 111352 0 0.0
text 746760 746762 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916752 916752 0 0.0
bss 90636 90636 0 0.0
text 614672 614672 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884240 884240 0 0.0
bss 91248 91248 0 0.0
text 607850 607850 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867240 867240 0 0.0
bss 90104 90104 0 0.0
text 591766 591766 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854260 854260 0 0.0
bss 89904 89904 0 0.0
text 582108 582110 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850416 850416 0 0.0
bss 89812 89812 0 0.0
text 577738 577740 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896328 896328 0 0.0
bss 90348 90348 0 0.0
text 617158 617156 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 891708 891708 0 0.0
bss 90640 90640 0 0.0
text 612078 612078 0 0.0

@andy31415 andy31415 merged commit 23b6442 into project-chip:master Jun 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the auto-commissioner-ensure-data branch June 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @woody-apple