-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PAA pathlen check to match spec #27207
Merged
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-pathlen-checks
Jun 15, 2023
Merged
Fix PAA pathlen check to match spec #27207
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-pathlen-checks
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Since Matter 1.1, PAAs are allowed to omit the pathlen optional field to basic constraints extension. The code did not do that - Fixes project-chip#27194 Changes in this PR: - Update all CryptoPAL backends to fix the path length checks - Added unit tests covering valid and invalid basic constraints around path lengths. Testing done: - Unit tests pass on both mbedTLS and BoringSSL/OpenSSL CryptoPAL
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
June 13, 2023 02:26
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 13, 2023 02:26
PR #27207: Size comparison from 212142b to 9b30bf6 Increases (10 builds for bl602, bl702, esp32, telink)
Decreases (14 builds for bl702, cc32xx, linux, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
emargolis
reviewed
Jun 13, 2023
emargolis
approved these changes
Jun 13, 2023
PR #27207: Size comparison from 212142b to 173e349 Increases above 0.2%:
Increases (38 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, telink)
Decreases (4 builds for linux, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now this all makes sense. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Changes in this PR:
Testing done: