Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clearer which Darwin test files are helpers vs tests. #27181

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Make it clearer which Darwin test files are helpers vs tests. #27181

merged 1 commit into from
Jun 13, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Moves the helpers into a TestHelpers folder.

@bzbarsky-apple
Make it clearer which Darwin test files are helpers vs tests.
98e5c6d 
Moves the helpers into a TestHelpers folder.
@github-actions github-actions bot added the darwin label Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

PR #27181: Size comparison from 12d8fec to 98e5c6d

Increases (11 builds for bl702, psoc6, qpg, telink)
platform target config section 12d8fec 98e5c6d change % change
bl702 lighting-app bl702+rpc .debug_info 50004108 50004109 1 0.0
.text 1052008 1052010 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 32271781 32271782 1 0.0
light cy8ckit_062s2_43012 .debug_info 26522657 26522659 2 0.0
qpg lighting-app qpg6105+debug (read/write) 1171008 1171016 8 0.0
.text 617848 617856 8 0.0
lock-app qpg6105+debug (read/write) 1140360 1140368 8 0.0
.text 587204 587212 8 0.0
telink bridge-app tlsr9518adk80d text 641886 641888 2 0.0
lighting-app tlsr9518adk80d text 678708 678710 2 0.0
lighting-app-rpc tlsr9518adk80d text 723394 723396 2 0.0
lighting-app-shell tlsr9518adk80d (read/write) 1065880 1065888 8 0.0
text 743748 743750 2 0.0
temperature-measurement-app tlsr9518adk80d text 576754 576756 2 0.0
thermostat tlsr9518adk80d text 616004 616006 2 0.0
Decreases (9 builds for bl602, esp32, k32w, psoc6, telink)
platform target config section 12d8fec 98e5c6d change % change
bl602 lighting-app bl602 (read/write) 1367930 1367922 -8 -0.0
.text 1047898 1047894 -4 -0.0
bl602+rpc (read/write) 1414918 1414910 -8 -0.0
.text 1079522 1079520 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1074720 1074718 -2 -0.0
.flash.text 1074720 1074718 -2 -0.0
m5stack (read/write) 494250 494246 -4 -0.0
.flash.rodata 244028 244024 -4 -0.0
k32w lock k32w0+release (read only) 556092 556076 -16 -0.0
.text 555556 555540 -16 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 26074796 26074794 -2 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 664852 664850 -2 -0.0
light-switch-app tlsr9518adk80d text 599650 599646 -4 -0.0
pump-controller-app tlsr9518adk80d text 581126 581124 -2 -0.0
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 12d8fec 98e5c6d change % change
bl602 lighting-app bl602 (read/write) 1367930 1367922 -8 -0.0
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047898 1047894 -4 -0.0
bl602+rpc (read/write) 1414918 1414910 -8 -0.0
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079522 1079520 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199903 1199903 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552411 1552411 0 0.0
.debug_aranges 149552 149552 0 0.0
.debug_frame 550552 550552 0 0.0
.debug_info 45052709 45052709 0 0.0
.debug_line 5608344 5608344 0 0.0
.debug_loc 3834332 3834332 0 0.0
.debug_ranges 398272 398272 0 0.0
.debug_str 4346356 4346356 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582173 582173 0 0.0
.symtab 175472 175472 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978352 978352 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289427 1289427 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711633 1711633 0 0.0
.debug_aranges 157856 157856 0 0.0
.debug_frame 578632 578632 0 0.0
.debug_info 50004108 50004109 1 0.0
.debug_line 6024708 6024708 0 0.0
.debug_loc 4037499 4037499 0 0.0
.debug_ranges 423768 423768 0 0.0
.debug_str 4772410 4772410 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643676 643676 0 0.0
.symtab 194032 194032 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1052008 1052010 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606178 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952093 952093 0 0.0
.debug_aranges 118920 118920 0 0.0
.debug_frame 406188 406188 0 0.0
.debug_info 23111424 23111424 0 0.0
.debug_line 2880814 2880814 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1726586 1726586 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107524 107524 0 0.0
.debug_str 3786770 3786770 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484580 484580 0 0.0
.symtab 287712 287712 0 0.0
.text 499512 499512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542259 542259 0 0.0
.app_xip_area 434877 434877 0 0.0
.bss 62360 62360 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529267 529267 0 0.0
.app_xip_area 416757 416757 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566659 566659 0 0.0
.app_xip_area 460213 460213 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531051 531051 0 0.0
.app_xip_area 422037 422037 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 986508 0 0.0
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 804472 0 0.0
BRD4187C (read/write) 1019784 1019784 0 0.0
.bss 159596 159596 0 0.0
.data 2788 2788 0 0.0
.text 857380 857380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069144 1069144 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 892812 0 0.0
window-app BRD4187C (read/write) 1088824 1088824 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943552 943552 0 0.0
esp32 all-clusters-app c3devkit (read only) 1074720 1074718 -2 -0.0
(read/write) 1583792 1583792 0 0.0
.dram0.bss 75280 75280 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 215432 215432 0 0.0
.flash.text 1074720 1074718 -2 -0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122763 1122763 0 0.0
(read/write) 494250 494246 -4 -0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244028 244024 -4 -0.0
.flash.text 1117379 1117379 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584796 584796 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584260 584260 0 0.0
light k32w0+release (read only) 583484 583484 0 0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582948 582948 0 0.0
lock k32w0+release (read only) 556092 556076 -16 -0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555556 555540 -16 -0.0
linux all-clusters-app debug (read only) 3267133 3267133 0 0.0
(read/write) 158208 158208 0 0.0
.bss 59488 59488 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 231496 231496 0 0.0
.text 2844693 2844693 0 0.0
all-clusters-minimal-app debug (read only) 3044957 3044957 0 0.0
(read/write) 145936 145936 0 0.0
.bss 58016 58016 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1096 1096 0 0.0
.rodata 224008 224008 0 0.0
.text 2635029 2635029 0 0.0
bridge-app debug (read only) 2524021 2524021 0 0.0
(read/write) 129808 129808 0 0.0
.bss 50264 50264 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 172680 172680 0 0.0
.text 2178565 2178565 0 0.0
chip-tool debug (read only) 15841393 15841393 0 0.0
(read/write) 734208 734208 0 0.0
.bss 26392 26392 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 697968 697968 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 698445 698445 0 0.0
.text 13438180 13438180 0 0.0
chip-tool-ipv6only arm64 (read only) 15214040 15214040 0 0.0
(read/write) 787368 787368 0 0.0
.bss 34376 34376 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 727736 727736 0 0.0
.dynamic 560 560 0 0.0
.got 16992 16992 0 0.0
.init 24 24 0 0.0
.init_array 232 232 0 0.0
.rodata 635992 635992 0 0.0
.text 12715364 12715364 0 0.0
lighting-app debug+rpc+ui (read only) 3388649 3388649 0 0.0
(read/write) 136312 136312 0 0.0
.bss 49760 49760 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 286132 286132 0 0.0
.text 2905106 2905106 0 0.0
lock-app debug (read only) 2616653 2616653 0 0.0
(read/write) 117208 117208 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 200104 200104 0 0.0
.text 2251941 2251941 0 0.0
ota-provider-app debug (read only) 2213397 2213397 0 0.0
(read/write) 103816 103816 0 0.0
.bss 44544 44544 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 153800 153800 0 0.0
.text 1917621 1917621 0 0.0
ota-requestor-app debug (read only) 2382285 2382285 0 0.0
(read/write) 111576 111576 0 0.0
.bss 46976 46976 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 157896 157896 0 0.0
.text 2073541 2073541 0 0.0
shell debug (read only) 2800473 2800473 0 0.0
(read/write) 146592 146592 0 0.0
.bss 58408 58408 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 199634 199634 0 0.0
.text 2433922 2433922 0 0.0
thermostat-no-ble arm64 (read only) 2616820 2616820 0 0.0
(read/write) 142968 142968 0 0.0
.bss 52360 52360 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79240 79240 0 0.0
.dynamic 560 560 0 0.0
.got 5520 5520 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 129712 129712 0 0.0
.text 2221636 2221636 0 0.0
tv-app debug (read only) 3319481 3319481 0 0.0
(read/write) 261640 261640 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 222136 222136 0 0.0
.text 2900706 2900706 0 0.0
tv-casting-app debug (read only) 9129529 9129529 0 0.0
(read/write) 219568 219568 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159200 159200 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 329740 329740 0 0.0
.text 8370546 8370546 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2497920 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1460604 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209952 1209952 0 0.0
bss 154745 154745 0 0.0
rodata 137380 137380 0 0.0
text 838768 838768 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1312804 1312804 0 0.0
bss 138075 138075 0 0.0
rodata 132816 132816 0 0.0
text 751200 751200 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148308 1148308 0 0.0
bss 153377 153377 0 0.0
rodata 111096 111096 0 0.0
text 804764 804764 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297177 1297177 0 0.0
.debug_aranges 148632 148632 0 0.0
.debug_frame 497676 497676 0 0.0
.debug_info 32271781 32271782 1 0.0
.debug_line 4034705 4034705 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2300833 2300833 0 0.0
.debug_rnglists 144093 144093 0 0.0
.debug_str 4350301 4350301 0 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750884 750884 0 0.0
.symtab 478784 478784 0 0.0
.text 0 0 0 0.0
1528460 1528460 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1660668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284935 1284935 0 0.0
.debug_aranges 147384 147384 0 0.0
.debug_frame 498620 498620 0 0.0
.debug_info 31733867 31733867 0 0.0
.debug_line 4040307 4040307 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2285664 2285664 0 0.0
.debug_rnglists 142539 142539 0 0.0
.debug_str 4333231 4333231 0 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699765 699765 0 0.0
.symtab 459904 459904 0 0.0
.text 1462252 1462252 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849560 849560 0 0.0
(read/write) 1593268 1593268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181388 181388 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122520 1122520 0 0.0
.debug_aranges 137720 137720 0 0.0
.debug_frame 462528 462528 0 0.0
.debug_info 26522657 26522659 2 0.0
.debug_line 3611221 3611221 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2126532 2126532 0 0.0
.debug_rnglists 132531 132531 0 0.0
.debug_str 4147305 4147305 0 0.0
.heap 849560 849560 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623349 623349 0 0.0
.symtab 425328 425328 0 0.0
.text 1401100 1401100 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104792 1104792 0 0.0
.debug_aranges 136112 136112 0 0.0
.debug_frame 456880 456880 0 0.0
.debug_info 26074796 26074794 -2 -0.0
.debug_line 3550580 3550580 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2100291 2100291 0 0.0
.debug_rnglists 130376 130376 0 0.0
.debug_str 4107804 4107804 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596481 596481 0 0.0
.symtab 416928 416928 0 0.0
.text 1406540 1406540 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1171008 1171016 8 0.0
.bss 99952 99952 0 0.0
.data 788 788 0 0.0
.text 617848 617856 8 0.0
lock-app qpg6105+debug (read/write) 1140360 1140368 8 0.0
.bss 94832 94832 0 0.0
.data 792 792 0 0.0
.text 587204 587212 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033916 1033916 0 0.0
bss 97660 97660 0 0.0
text 707596 707596 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961064 961064 0 0.0
bss 96176 96176 0 0.0
text 664852 664850 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928784 928784 0 0.0
bss 100308 100308 0 0.0
text 641886 641888 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860452 860452 0 0.0
bss 89968 89968 0 0.0
text 585022 585022 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876776 876776 0 0.0
bss 90136 90136 0 0.0
text 599650 599646 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965032 965032 0 0.0
bss 98500 98500 0 0.0
text 678708 678710 2 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976412 976412 0 0.0
bss 102748 102748 0 0.0
text 686232 686232 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034132 1034132 0 0.0
bss 100064 100064 0 0.0
text 723394 723396 2 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065880 1065888 8 0.0
bss 111140 111140 0 0.0
text 743748 743750 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915524 915524 0 0.0
bss 90632 90632 0 0.0
text 613650 613650 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883052 883052 0 0.0
bss 91244 91244 0 0.0
text 606866 606866 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866012 866012 0 0.0
bss 90100 90100 0 0.0
text 590740 590740 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853072 853072 0 0.0
bss 89900 89900 0 0.0
text 581126 581124 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849228 849228 0 0.0
bss 89808 89808 0 0.0
text 576754 576756 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894972 894972 0 0.0
bss 90344 90344 0 0.0
text 616004 616006 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890352 890352 0 0.0
bss 90636 90636 0 0.0
text 610926 610926 0 0.0

andy31415
andy31415 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

General comment from non-darwin code maintainer:

  • MTRTest* stutters a lot in these file names. Test Itself does as well like CHIPTest/TestHelper/MTRTestKeys ...
  • Names not containing helpers/support/util are generally easier to remember and maintain.

@andy31415 andy31415 merged commit 7aa29f4 into project-chip:master Jun 13, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-tests-group branch June 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@andy31415 andy31415 Awaiting requested review from andy31415

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @ksperling-apple