Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid endpoint composition from lighting-app #27133

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Remove invalid endpoint composition from lighting-app #27133

merged 1 commit into from
Jun 8, 2023

Conversation

tcarmelveilleux
Copy link
Contributor

Problem:

  • lighting-app example has Scenes and Groups clusters on Endpoint 0, which is invalid.

Fixes:

  • Remove clusters that don't belong on Endpoint 0
    • LevelControl
    • OnOff
    • Groups
    • Scenes

Testing done:

  • TC_RR_1_1 still passes
  • TC_LVL_2_1 still passes

@tennessee-google
Remove invalid endpoint composition from lighting-app
2c7c12d 
Problem:
- lighting-app example has Scenes and Groups clusters on Endpoint 0, which is invalid.

Fixes:
- Remove clusters that don't belong on Endpoint 0
  - LevelControl
  - OnOff
  - Groups
  - Scenes

Testing done:
- TC_RR_1_1 still passes
- TC_LVL_2_1 still passes
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

PR #27133: Size comparison from dd21e4e to 2c7c12d

Increases (15 builds for bl602, cc32xx, cyw30739, esp32, psoc6, qpg, telink)
platform target config section dd21e4e 2c7c12d change % change
bl602 lighting-app bl602 .text 1047894 1047896 2 0.0
bl602+rpc .text 1079518 1079520 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 23076175 23076176 1 0.0
cyw30739 switch cyw930739m2evb_01 (read/write) 531027 531035 8 0.0
.app_xip_area 422013 422021 8 0.0
esp32 all-clusters-app c3devkit (read only) 1076326 1076328 2 0.0
.flash.text 1076326 1076328 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 32222633 32222634 1 0.0
light cy8ckit_062s2_43012 (read only) 849544 849560 16 0.0
.heap 849544 849560 16 0.0
qpg lighting-app qpg6105+debug (read/write) 1170564 1170572 8 0.0
.text 617660 617668 8 0.0
lock-app qpg6105+debug (read/write) 1139844 1139852 8 0.0
.text 586944 586952 8 0.0
telink all-clusters-app tlsr9518adk80d text 707578 707580 2 0.0
light-switch-app tlsr9518adk80d text 599630 599632 2 0.0
lighting-app-factory-data tlsr9518adk80d text 686212 686214 2 0.0
lighting-app-shell tlsr9518adk80d text 743728 743730 2 0.0
lock-app tlsr9518adk80d text 613632 613634 2 0.0
ota-requestor-app tlsr9518adk80d text 606846 606850 4 0.0
Decreases (16 builds for bl702, cyw30739, efr32, k32w, linux, psoc6, telink)
platform target config section dd21e4e 2c7c12d change % change
bl702 lighting-app bl702 .debug_info 44992431 44992430 -1 -0.0
.text 978320 978318 -2 -0.0
bl702+rpc .debug_info 4994006 49940067 -1 -0.0
.text 1051978 1051976 -2 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542371 542243 -128 -0.0
.app_xip_area 434981 434861 -120 -0.0
.bss 62368 62360 -8 -0.0
lock cyw930739m2evb_01 (read/write) 529259 529251 -8 -0.0
.app_xip_area 416749 416741 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1019896 1019768 -128 -0.0
.bss 159604 159596 -8 -0.0
.text 857484 857364 -120 -0.0
k32w light k32w0+release (read only) 583452 583436 -16 -0.0
.text 582916 582900 -16 -0.0
linux lighting-app debug+rpc+ui (read only) 3386577 3386417 -160 -0.0
(read/write) 136432 136304 -128 -0.1
.bss 49792 49760 -32 -0.1
.data.rel.ro 77056 76960 -96 -0.1
.rodata 286196 286132 -64 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 31685786 31685785 -1 -0.0
light cy8ckit_062s2_43012 (read/write) 1593404 1593268 -136 -0.0
.bss 181404 181388 -16 -0.0
.debug_info 26484254 26484206 -48 -0.0
.text 1401220 1401100 -120 -0.0
telink contact-sensor-app tlsr9518adk80d text 585004 585002 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 965148 965016 -132 -0.0
bss 98512 98500 -12 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 976520 976396 -124 -0.0
bss 102760 102748 -12 -0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1034240 1034108 -132 -0.0
bss 100076 100064 -12 -0.0
text 723376 723374 -2 -0.0
lighting-app-shell tlsr9518adk80d (read/write) 1065996 1065864 -132 -0.0
bss 111152 111140 -12 -0.0
thermostat tlsr9518adk80d (read/write) 894956 894948 -8 -0.0
text 615986 615984 -2 -0.0
window-covering tlsr9518adk80d text 610908 610906 -2 -0.0
Full report (53 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, telink)
platform target config section dd21e4e 2c7c12d change % change
bl602 lighting-app bl602 (read/write) 1367922 1367922 0 0.0
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047894 1047896 2 0.0
bl602+rpc (read/write) 1414910 1414910 0 0.0
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079518 1079520 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199871 1199871 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552228 0 0.0
.debug_aranges 149424 149424 0 0.0
.debug_frame 550040 550040 0 0.0
.debug_info 44992431 44992430 -1 -0.0
.debug_line 5604316 5604316 0 0.0
.debug_loc 3830718 3830718 0 0.0
.debug_ranges 398096 398096 0 0.0
.debug_str 4343615 4343615 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582046 0 0.0
.symtab 175456 175456 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978320 978318 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289395 1289395 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711296 1711296 0 0.0
.debug_aranges 157712 157712 0 0.0
.debug_frame 578052 578052 0 0.0
.debug_info 4994006 49940067 -1 -0.0
.debug_line 6020358 6020358 0 0.0
.debug_loc 4033819 4033819 0 0.0
.debug_ranges 423576 423576 0 0.0
.debug_str 4769091 4769091 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 643549 0 0.0
.symtab 194016 194016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051978 1051976 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606178 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952074 0 0.0
.debug_aranges 118800 118800 0 0.0
.debug_frame 405752 405752 0 0.0
.debug_info 23076175 23076176 1 0.0
.debug_line 2878685 2878685 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1724555 1724555 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107433 107433 0 0.0
.debug_str 3784160 3784160 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 484563 0 0.0
.symtab 287712 287712 0 0.0
.text 499512 499512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542371 542243 -128 -0.0
.app_xip_area 434981 434861 -120 -0.0
.bss 62368 62360 -8 -0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529259 529251 -8 -0.0
.app_xip_area 416749 416741 -8 -0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566651 566651 0 0.0
.app_xip_area 460205 460205 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531027 531035 8 0.0
.app_xip_area 422013 422021 8 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 986508 0 0.0
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 804472 0 0.0
BRD4187C (read/write) 1019896 1019768 -128 -0.0
.bss 159604 159596 -8 -0.0
.data 2788 2788 0 0.0
.text 857484 857364 -120 -0.0
lock-app BRD4161A+wf200 (read/write) 1069144 1069144 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 892812 0 0.0
window-app BRD4187C (read/write) 1088800 1088800 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943528 943528 0 0.0
esp32 all-clusters-app c3devkit (read only) 1076326 1076328 2 0.0
(read/write) 1584984 1584984 0 0.0
.dram0.bss 75760 75760 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 216128 216128 0 0.0
.flash.text 1076326 1076328 2 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122731 1122731 0 0.0
(read/write) 494246 494246 0 0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244024 244024 0 0.0
.flash.text 1117347 1117347 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584748 584748 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584212 584212 0 0.0
light k32w0+release (read only) 583452 583436 -16 -0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582916 582900 -16 -0.0
lock k32w0+release (read only) 556044 556044 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555508 555508 0 0.0
linux all-clusters-app debug (read only) 3264453 3264453 0 0.0
(read/write) 158168 158168 0 0.0
.bss 59456 59456 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231496 231496 0 0.0
.text 2842037 2842037 0 0.0
all-clusters-minimal-app debug (read only) 3042277 3042277 0 0.0
(read/write) 145896 145896 0 0.0
.bss 57984 57984 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224008 224008 0 0.0
.text 2632373 2632373 0 0.0
bridge-app debug (read only) 2521341 2521341 0 0.0
(read/write) 129768 129768 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172680 172680 0 0.0
.text 2175909 2175909 0 0.0
chip-tool debug (read only) 15574585 15574585 0 0.0
(read/write) 709696 709696 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 673424 673424 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 687573 687573 0 0.0
.text 13240132 13240132 0 0.0
chip-tool-ipv6only arm64 (read only) 14890436 14890436 0 0.0
(read/write) 762712 762712 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703320 703320 0 0.0
.dynamic 560 560 0 0.0
.got 16728 16728 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623672 623672 0 0.0
.text 12462500 12462500 0 0.0
lighting-app debug+rpc+ui (read only) 3386577 3386417 -160 -0.0
(read/write) 136432 136304 -128 -0.1
.bss 49792 49760 -32 -0.1
.data 2704 2704 0 0.0
.data.rel.ro 77056 76960 -96 -0.1
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286196 286132 -64 -0.0
.text 2902898 2902898 0 0.0
lock-app debug (read only) 2613973 2613973 0 0.0
(read/write) 117200 117200 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200104 200104 0 0.0
.text 2249285 2249285 0 0.0
ota-provider-app debug (read only) 2211085 2211085 0 0.0
(read/write) 103792 103792 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153800 153800 0 0.0
.text 1915333 1915333 0 0.0
ota-requestor-app debug (read only) 2379605 2379605 0 0.0
(read/write) 111552 111552 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157896 157896 0 0.0
.text 2070885 2070885 0 0.0
shell debug (read only) 2798145 2798145 0 0.0
(read/write) 146552 146552 0 0.0
.bss 58376 58376 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199634 199634 0 0.0
.text 2431618 2431618 0 0.0
thermostat-no-ble arm64 (read only) 2607084 2607084 0 0.0
(read/write) 143032 143032 0 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129608 129608 0 0.0
.text 2211700 2211700 0 0.0
tv-app debug (read only) 3316145 3316145 0 0.0
(read/write) 261632 261632 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222136 222136 0 0.0
.text 2897394 2897394 0 0.0
tv-casting-app debug (read only) 9116385 9116385 0 0.0
(read/write) 219560 219560 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159200 159200 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 329484 329484 0 0.0
.text 8357682 8357682 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297175 1297175 0 0.0
.debug_aranges 148512 148512 0 0.0
.debug_frame 497240 497240 0 0.0
.debug_info 32222633 32222634 1 0.0
.debug_line 4032479 4032479 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2298790 2298790 0 0.0
.debug_rnglists 144002 144002 0 0.0
.debug_str 4347691 4347691 0 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750867 750867 0 0.0
.symtab 478784 478784 0 0.0
.text 0 0 0 0.0
1528460 1528460 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1660668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284933 1284933 0 0.0
.debug_aranges 147264 147264 0 0.0
.debug_frame 498184 498184 0 0.0
.debug_info 31685786 31685785 -1 -0.0
.debug_line 4038033 4038033 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2283622 2283622 0 0.0
.debug_rnglists 142448 142448 0 0.0
.debug_str 4330621 4330621 0 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699748 699748 0 0.0
.symtab 459904 459904 0 0.0
.text 1462252 1462252 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849544 849560 16 0.0
(read/write) 1593404 1593268 -136 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181404 181388 -16 -0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122518 1122518 0 0.0
.debug_aranges 137600 137600 0 0.0
.debug_frame 462092 462092 0 0.0
.debug_info 26484254 26484206 -48 -0.0
.debug_line 3609019 3609019 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2124490 2124490 0 0.0
.debug_rnglists 132440 132440 0 0.0
.debug_str 4144695 4144695 0 0.0
.heap 849544 849560 16 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623332 623332 0 0.0
.symtab 425328 425328 0 0.0
.text 1401220 1401100 -120 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104790 1104790 0 0.0
.debug_aranges 135992 135992 0 0.0
.debug_frame 456444 456444 0 0.0
.debug_info 26037759 26037759 0 0.0
.debug_line 3548402 3548402 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2098249 2098249 0 0.0
.debug_rnglists 130285 130285 0 0.0
.debug_str 4105194 4105194 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596464 596464 0 0.0
.symtab 416928 416928 0 0.0
.text 1406540 1406540 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170564 1170572 8 0.0
.bss 99944 99944 0 0.0
.data 852 852 0 0.0
.text 617660 617668 8 0.0
lock-app qpg6105+debug (read/write) 1139844 1139852 8 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586944 586952 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033900 1033900 0 0.0
bss 97660 97660 0 0.0
text 707578 707580 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961048 961048 0 0.0
bss 96176 96176 0 0.0
text 664836 664836 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928768 928768 0 0.0
bss 100308 100308 0 0.0
text 641872 641872 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860436 860436 0 0.0
bss 89968 89968 0 0.0
text 585004 585002 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876760 876760 0 0.0
bss 90136 90136 0 0.0
text 599630 599632 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965148 965016 -132 -0.0
bss 98512 98500 -12 -0.0
text 678690 678690 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976520 976396 -124 -0.0
bss 102760 102748 -12 -0.0
text 686212 686214 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034240 1034108 -132 -0.0
bss 100076 100064 -12 -0.0
text 723376 723374 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065996 1065864 -132 -0.0
bss 111152 111140 -12 -0.0
text 743728 743730 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915508 915508 0 0.0
bss 90632 90632 0 0.0
text 613632 613634 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883036 883036 0 0.0
bss 91244 91244 0 0.0
text 606846 606850 4 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865996 865996 0 0.0
bss 90100 90100 0 0.0
text 590724 590724 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853056 853056 0 0.0
bss 89900 89900 0 0.0
text 581106 581106 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849212 849212 0 0.0
bss 89808 89808 0 0.0
text 576738 576738 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894956 894948 -8 -0.0
bss 90344 90344 0 0.0
text 615986 615984 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890328 890328 0 0.0
bss 90636 90636 0 0.0
text 610908 610906 -2 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should note, though, that:

  1. Except for Groups these were all disabled, so not actually present on the endpoint.
  2. For groups, I don't recall where the argument about whether EP0 can be in a group ended up.

@andy31415
Copy link
Contributor

@tcarmelveilleux now that matter-lint supports these, should the group check become a default reject in our linter rules?

@tcarmelveilleux
Copy link
Contributor Author

@tcarmelveilleux now that matter-lint supports these, should the group check become a default reject in our linter rules?

Scenes yes, group not yet...

@andy31415 andy31415 merged commit e312a10 into project-chip:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcarmelveilleux @andy31415 @bzbarsky-apple @jmartinez-silabs @tennessee-google