Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Smoke CO Alarm #27123

Merged
merged 27 commits into from
Jul 21, 2023
Merged

Conversation

ericzijian1994
Copy link
Contributor

@ericzijian1994 ericzijian1994 commented Jun 7, 2023

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the event bits as you have them here, but file a follow-up issue to do something better. We really can't depend on real devices not having random other events going on...

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so this is not blocked on me, but:

  1. Please make sure the problem about expressed state is reflected in the test plan issue.
  2. Please fix the backwards PICS for the WaitForMs.

@mhazley
Copy link
Contributor

mhazley commented Jul 21, 2023

Generally, test plan step numbers in the YAML would help with following these!

@mergify mergify bot merged commit 47cfe96 into project-chip:master Jul 21, 2023
@ericzijian1994 ericzijian1994 deleted the smco_tests branch July 25, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants