-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Smoke CO Alarm #27123
Add tests for Smoke CO Alarm #27123
Conversation
f634611
to
3343760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with the event bits as you have them here, but file a follow-up issue to do something better. We really can't depend on real devices not having random other events going on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so this is not blocked on me, but:
- Please make sure the problem about expressed state is reflected in the test plan issue.
- Please fix the backwards PICS for the WaitForMs.
Generally, test plan step numbers in the YAML would help with following these! |
Add TC-SMCO-* based on Test Plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/2596