-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][Lighitng-app]Enable Events on some device management clusters. #27086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
June 5, 2023 19:53
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 5, 2023 19:53
examples/lighting-app/silabs/data_model/lighting-thread-app.matter
Outdated
Show resolved
Hide resolved
examples/lighting-app/silabs/data_model/lighting-thread-app.matter
Outdated
Show resolved
Hide resolved
examples/lighting-app/silabs/data_model/lighting-wifi-app.matter
Outdated
Show resolved
Hide resolved
PR #27086: Size comparison from 9828293 to 502e875 Increases above 0.2%:
Increases (10 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Decreases (11 builds for bl702, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ource and power source config cluster
…en't emited by the app
jmartinez-silabs
force-pushed
the
add_event_list
branch
from
July 7, 2023 13:59
502e875
to
c164ce5
Compare
PR #27086: Size comparison from a4a0f21 to c164ce5 Increases above 0.2%:
Increases (11 builds for efr32, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (20 builds for bl602, bl702, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
approved these changes
Jul 7, 2023
woody-apple
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some failures caught during TE1 with Silabs Lighting-app
Enables needed events on
It also enables the Power Source Config cluster on endpoint 0 and Power Source cluster on endpoint 1.