-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add single/double constraint type supports #27075
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_SingleDoubleConstraint
Jun 9, 2023
Merged
[matter_yamltests] Add single/double constraint type supports #27075
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_SingleDoubleConstraint
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
June 5, 2023 13:55
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 5, 2023 13:55
PR #27075: Size comparison from 991f367 to 4599815 Full report (1 build for cc32xx)
|
vivien-apple
force-pushed
the
MatterYamlTests_SingleDoubleConstraint
branch
from
June 5, 2023 14:14
4599815
to
2d3de28
Compare
PR #27075: Size comparison from 991f367 to 2d3de28 Increases (10 builds for bl602, bl702, cc32xx, k32w, psoc6, telink)
Decreases (7 builds for bl602, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 5, 2023
andy31415
reviewed
Jun 5, 2023
vivien-apple
force-pushed
the
MatterYamlTests_SingleDoubleConstraint
branch
from
June 6, 2023 09:38
2d3de28
to
01d80ff
Compare
vivien-apple
force-pushed
the
MatterYamlTests_SingleDoubleConstraint
branch
from
June 6, 2023 09:41
01d80ff
to
bc8efc7
Compare
PR #27075: Size comparison from d700f2f to bc8efc7 Increases (8 builds for bl602, cc32xx, cyw30739, psoc6, telink)
Decreases (10 builds for bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 6, 2023
andy31415
reviewed
Jun 6, 2023
vivien-apple
force-pushed
the
MatterYamlTests_SingleDoubleConstraint
branch
from
June 8, 2023 07:46
bc8efc7
to
9c61d97
Compare
PR #27075: Size comparison from d4c7d47 to 9c61d97 Increases (6 builds for esp32, nrfconnect, telink)
Decreases (11 builds for bl602, bl702, esp32, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With
matter_yamltests
there is no constraint forsingle
/double
. This PR adds such constraint types.