-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runner run function to be async. #27048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vivien-apple can you please take a look to make sure there are no issues with this? |
krypton36
force-pushed
the
UpdateRunnerToBeAsync
branch
from
June 2, 2023 18:13
7eac9d7
to
43f9999
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
June 2, 2023 18:13
pullapprove
bot
requested review from
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 2, 2023 18:13
bzbarsky-apple
approved these changes
Jun 2, 2023
PR #27048: Size comparison from 7dcc847 to 43f9999 Increases (1 build for nrfconnect)
Decreases (1 build for cc32xx)
Full report (13 builds for cc32xx, efr32, linux, mbed, nrfconnect, qpg)
|
vivien-apple
approved these changes
Jun 5, 2023
andy31415
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the runner.py run function to be async and moving the loop one level. This causes issues if the caller is already using an asynio loop, which test harness is doing.
This is the error I see in Test Harness: