Remove the incorrect GroupKeySetIDs field from the KeySetReadAllIndices command. #27044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #27044: Size comparison from e19d9d8 to 7254b27 Increases (4 builds for cc32xx, linux, psoc6)
Decreases (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jun 2, 2023
woody-apple
approved these changes
Jun 5, 2023
|
@bzbarsky-apple seems we can merge after we merge with the removal of bridge-app.matter. |
|
@andy31415 Yes, I am waiting on one more sanity check before I do that. |
bzbarsky-apple
force-pushed
the
remove-bogus-field
branch
from
51ec643 to
b6928af
Compare
…es command. This field does not exist in the spec. This is safe to do in terms of compat because the generated command parsing code only parses the fields that are actually present and does not error out if mandatory fields are missing; instead if uses type-default values for them. So commands updated clients send will still be parse-able by servers that had this field in their XML. Fixes part of project-chip#25642 For the Darwin codegen, I just special-cased this command in the templates for now, but if we end up with more commands going from having required fields to not having them we can figure out a more automated solution.
bzbarsky-apple
force-pushed
the
remove-bogus-field
branch
from
b6928af to
f35a5bd
Compare
|
PR #27044: Size comparison from 4f6923f to f35a5bd Increases (3 builds for cc32xx, linux, psoc6)
Decreases (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first changeset is manually written. The second one is just running codegen.
This field does not exist in the spec.
This is safe to do in terms of compat because the generated command parsing code
only parses the fields that are actually present and does not error out if
mandatory fields are missing; instead if uses type-default values for them. So
commands updated clients send will still be parse-able by servers that had this
field in their XML.
Fixes part of #25642
For the Darwin codegen, I just special-cased this command in the templates for
now, but if we end up with more commands going from having required fields to
not having them we can figure out a more automated solution.